diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-06-29 17:03:10 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-06-29 17:03:10 +0100 |
| commit | e1a5bd866e5e27a9ee2d37bcdc5e817c1fa8672d (patch) | |
| tree | 2f1cb8826b1fa0ac6b693377118ca13a561332b2 /editors/code/src/commands.ts | |
| parent | 86f1556f7c1fa2cf04753be90c83afc1f825d7de (diff) | |
| parent | 64a49589e74447da668bd5acab8375206a10253f (diff) | |
| parent | 2a18ef0b0910af2515eab6fb1354a066b738c513 (diff) | |
Merge #5096 #5097
5096: Fix handling of whitespace when applying SSR within macro expansions. r=matklad a=davidlattimore
I originally did replacement by passing in the full file text. Then as some point I thought I could do without it. Turns out calling .text() on a node coming from a macro expansion isn't a great idea, especially when you then try and use ranges from the original source to cut that text. The test I added here actually panics without the rest of this change (sorry I didn't notice sooner).
5097: Fix SSR prompt following #4919 r=matklad a=davidlattimore
Co-authored-by: David Lattimore <[email protected]>