Merge #3629

3629: Alternative aproach to plugin auto update r=matklad a=matklad

This is very much WIP (as in, I haven't run this once), but I like the result so far.

cc @Veetaha 

The primary focus here on simplification:

* local simplification of data structures and control-flow: using union of strings instead of an enum, using unwrapped GitHub API responses
* global simplification of control flow: all logic is now in `main.ts`, implemented as linear functions without abstractions. This is stateful side-effective code, so arguments from [Carmack](http://number-none.com/blow/john_carmack_on_inlined_code.html) very much apply. We need all user interractions, all mutations, and all network requests to happen in a single file. 
* as a side-effect of condensing everything to functions, we can get rid of various enums. The enums were basically a reified control flow:

```
enum E { A, B }

fn foo() -> E {
    if cond { E::A } else { E::B }
}

fn bar(e: E) {
    match e {
        E::A => do_a(),
        E::B => do_b(),
    }
}

==>>

fn all() {
    if cond { do_a() } else { do_b() }
}
```

* simplification of model: we don't need to reinstall on settings update, we can just ask the user to reload, we don't need to handle nightly=>stable fallback, we can ask the user to reinstall extension, (todo) we don't need to parse out the date from the version, we can use build id for nightly and for stable we can write the info directly into package.json.

Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 0 insertions, 63 deletions

diff --git a/editors/code/src/installation/interfaces.ts b/editors/code/src/installation/interfaces.ts
deleted file mode 100644
index 1a8ea0884..000000000
--- a/editors/code/src/installation/interfaces.ts
+++ /dev/null
@@ -1,63 +0,0 @@
-export interface GithubRepo {
-    name: string;
-    owner: string;
-}
-
-/**
- * Metadata about particular artifact retrieved from GitHub releases.
- */
-export interface ArtifactReleaseInfo {
-    releaseDate: Date;
-    releaseName: string;
-    downloadUrl: string;
-}
-
-/**
- * Represents the source of a an artifact which is either specified by the user
- * explicitly, or bundled by this extension from GitHub releases.
- */
-export type ArtifactSource = ArtifactSource.ExplicitPath | ArtifactSource.GithubRelease;
-
-export namespace ArtifactSource {
-    /**
-     * Type tag for `ArtifactSource` discriminated union.
-     */
-    export const enum Type { ExplicitPath, GithubRelease }
-
-    export interface ExplicitPath {
-        type: Type.ExplicitPath;
-
-        /**
-         * Filesystem path to the binary specified by the user explicitly.
-         */
-        path: string;
-    }
-
-    export interface GithubRelease {
-        type: Type.GithubRelease;
-
-        /**
-         * Repository where the binary is stored.
-         */
-        repo: GithubRepo;
-
-
-        // FIXME: add installationPath: string;
-
-        /**
-         * Directory on the filesystem where the bundled binary is stored.
-         */
-        dir: string;
-
-        /**
-         * Name of the binary file. It is stored under the same name on GitHub releases
-         * and in local `.dir`.
-         */
-        file: string;
-
-        /**
-         * Tag of github release that denotes a version required by this extension.
-         */
-        tag: string;
-    }
-}