diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-07-06 08:36:49 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-07-06 08:36:49 +0100 |
commit | 816a39cb54766c1dc8960620142659e716f485dc (patch) | |
tree | d821b907d1aae6b5a222454a2d56b07a9b87204d /editors/code/src/persistent_state.ts | |
parent | 6546a684704fa90d3611c75b4167f63ff1851ee5 (diff) | |
parent | 46163acf62a94ec603be444294e119933c953a84 (diff) |
Merge #5229
5229: Improve client logging (use output channel and more log levels) r=matklad a=Veetaha
The improvements:
* Separate output channel allows viewing the logs belonging to only our extension (without the intervention of other vscode extensions)
* All the objects in the output channel are always expanded so users only need to `Ctrl + A and Ctrl + C` to copy the entire output to send us and nothing more (e.g. currently users need to expand the object which is not obvious for them and we may lose the logs this way, see two comments: https://github.com/rust-analyzer/rust-analyzer/issues/5009#issuecomment-651361137
* More log levels allows us to be more granular in disabling only optional verbose debug-level output and leave the logs for us as developers to understand the context of user issues.
* For `log.error(...)` invocations we reveal `Rust Analyzer Client` channel automatically so that users don't have to do any additional actions to get the logs output window visible
Demo:
![image](https://user-images.githubusercontent.com/36276403/86535275-d7795f80-bee7-11ea-8c30-135c83c1bc7d.png)
Co-authored-by: Veetaha <[email protected]>
Diffstat (limited to 'editors/code/src/persistent_state.ts')
-rw-r--r-- | editors/code/src/persistent_state.ts | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/editors/code/src/persistent_state.ts b/editors/code/src/persistent_state.ts index 138d11b89..5705eed81 100644 --- a/editors/code/src/persistent_state.ts +++ b/editors/code/src/persistent_state.ts | |||
@@ -4,7 +4,7 @@ import { log } from './util'; | |||
4 | export class PersistentState { | 4 | export class PersistentState { |
5 | constructor(private readonly globalState: vscode.Memento) { | 5 | constructor(private readonly globalState: vscode.Memento) { |
6 | const { lastCheck, releaseId, serverVersion } = this; | 6 | const { lastCheck, releaseId, serverVersion } = this; |
7 | log.debug("PersistentState: ", { lastCheck, releaseId, serverVersion }); | 7 | log.info("PersistentState:", { lastCheck, releaseId, serverVersion }); |
8 | } | 8 | } |
9 | 9 | ||
10 | /** | 10 | /** |