Merge #3629

3629: Alternative aproach to plugin auto update r=matklad a=matklad

This is very much WIP (as in, I haven't run this once), but I like the result so far.

cc @Veetaha 

The primary focus here on simplification:

* local simplification of data structures and control-flow: using union of strings instead of an enum, using unwrapped GitHub API responses
* global simplification of control flow: all logic is now in `main.ts`, implemented as linear functions without abstractions. This is stateful side-effective code, so arguments from [Carmack](http://number-none.com/blow/john_carmack_on_inlined_code.html) very much apply. We need all user interractions, all mutations, and all network requests to happen in a single file. 
* as a side-effect of condensing everything to functions, we can get rid of various enums. The enums were basically a reified control flow:

```
enum E { A, B }

fn foo() -> E {
    if cond { E::A } else { E::B }
}

fn bar(e: E) {
    match e {
        E::A => do_a(),
        E::B => do_b(),
    }
}

==>>

fn all() {
    if cond { do_a() } else { do_b() }
}
```

* simplification of model: we don't need to reinstall on settings update, we can just ask the user to reload, we don't need to handle nightly=>stable fallback, we can ask the user to reinstall extension, (todo) we don't need to parse out the date from the version, we can use build id for nightly and for stable we can write the info directly into package.json.

Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 28 insertions, 36 deletions

diff --git a/editors/code/src/persistent_state.ts b/editors/code/src/persistent_state.ts
index 13095b806..138d11b89 100644
--- a/editors/code/src/persistent_state.ts
+++ b/editors/code/src/persistent_state.ts
@@ -1,49 +1,41 @@
 import * as vscode from 'vscode';
-import { log } from "./util";
+import { log } from './util';
 
 export class PersistentState {
-    constructor(private readonly ctx: vscode.ExtensionContext) {
+    constructor(private readonly globalState: vscode.Memento) {
+        const { lastCheck, releaseId, serverVersion } = this;
+        log.debug("PersistentState: ", { lastCheck, releaseId, serverVersion });
     }
 
-    readonly installedNightlyExtensionReleaseDate = new DateStorage(
-        "installed-nightly-extension-release-date",
-        this.ctx.globalState
-    );
-    readonly serverReleaseDate = new DateStorage("server-release-date", this.ctx.globalState);
-    readonly serverReleaseTag = new Storage<null | string>("server-release-tag", this.ctx.globalState, null);
-}
-
-
-export class Storage<T> {
-    constructor(
-        private readonly key: string,
-        private readonly storage: vscode.Memento,
-        private readonly defaultVal: T
-    ) { }
-
-    get(): T {
-        const val = this.storage.get(this.key, this.defaultVal);
-        log.debug(this.key, "==", val);
-        return val;
+    /**
+     * Used to check for *nightly* updates once an hour.
+     */
+    get lastCheck(): number | undefined {
+        return this.globalState.get("lastCheck");
     }
-    async set(val: T) {
-        log.debug(this.key, "=", val);
-        await this.storage.update(this.key, val);
+    async updateLastCheck(value: number) {
+        await this.globalState.update("lastCheck", value);
     }
-}
-export class DateStorage {
-    inner: Storage<null | string>;
 
-    constructor(key: string, storage: vscode.Memento) {
-        this.inner = new Storage(key, storage, null);
+    /**
+     * Release id of the *nightly* extension.
+     * Used to check if we should update.
+     */
+    get releaseId(): number | undefined {
+        return this.globalState.get("releaseId");
     }
-
-    get(): null | Date {
-        const dateStr = this.inner.get();
-        return dateStr ? new Date(dateStr) : null;
+    async updateReleaseId(value: number) {
+        await this.globalState.update("releaseId", value);
     }
 
-    async set(date: null | Date) {
-        await this.inner.set(date ? date.toString() : null);
+    /**
+     * Version of the extension that installed the server.
+     * Used to check if we need to update the server.
+     */
+    get serverVersion(): string | undefined {
+        return this.globalState.get("serverVersion");
+    }
+    async updateServerVersion(value: string | undefined) {
+        await this.globalState.update("serverVersion", value);
     }
 }