Merge #3629

3629: Alternative aproach to plugin auto update r=matklad a=matklad

This is very much WIP (as in, I haven't run this once), but I like the result so far.

cc @Veetaha 

The primary focus here on simplification:

* local simplification of data structures and control-flow: using union of strings instead of an enum, using unwrapped GitHub API responses
* global simplification of control flow: all logic is now in `main.ts`, implemented as linear functions without abstractions. This is stateful side-effective code, so arguments from [Carmack](http://number-none.com/blow/john_carmack_on_inlined_code.html) very much apply. We need all user interractions, all mutations, and all network requests to happen in a single file. 
* as a side-effect of condensing everything to functions, we can get rid of various enums. The enums were basically a reified control flow:

```
enum E { A, B }

fn foo() -> E {
    if cond { E::A } else { E::B }
}

fn bar(e: E) {
    match e {
        E::A => do_a(),
        E::B => do_b(),
    }
}

==>>

fn all() {
    if cond { do_a() } else { do_b() }
}
```

* simplification of model: we don't need to reinstall on settings update, we can just ask the user to reload, we don't need to handle nightly=>stable fallback, we can ask the user to reinstall extension, (todo) we don't need to parse out the date from the version, we can use build id for nightly and for stable we can write the info directly into package.json.

Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 0 insertions, 54 deletions

diff --git a/editors/code/src/util.ts b/editors/code/src/util.ts
index 2bfc145e6..978a31751 100644
--- a/editors/code/src/util.ts
+++ b/editors/code/src/util.ts
@@ -1,6 +1,5 @@
 import * as lc from "vscode-languageclient";
 import * as vscode from "vscode";
-import { promises as dns } from "dns";
 import { strict as nativeAssert } from "assert";
 
 export function assert(condition: boolean, explanation: string): asserts condition {
@@ -31,22 +30,6 @@ export const log = new class {
         // eslint-disable-next-line no-console
         console.error(message, ...optionalParams);
     }
-
-    downloadError(err: Error, artifactName: string, repoName: string) {
-        vscode.window.showErrorMessage(
-            `Failed to download the rust-analyzer ${artifactName} from ${repoName} ` +
-            `GitHub repository: ${err.message}`
-        );
-        log.error(err);
-        dns.resolve('example.com').then(
-            addrs => log.debug("DNS resolution for example.com was successful", addrs),
-            err => log.error(
-                "DNS resolution for example.com failed, " +
-                "there might be an issue with Internet availability",
-                err
-            )
-        );
-    }
 };
 
 export async function sendRequestWithRetry<TParam, TRet>(
@@ -86,17 +69,6 @@ function sleep(ms: number) {
     return new Promise(resolve => setTimeout(resolve, ms));
 }
 
-export function notReentrant<TThis, TParams extends any[], TRet>(
-    fn: (this: TThis, ...params: TParams) => Promise<TRet>
-): typeof fn {
-    let entered = false;
-    return function(...params) {
-        assert(!entered, `Reentrancy invariant for ${fn.name} is violated`);
-        entered = true;
-        return fn.apply(this, params).finally(() => entered = false);
-    };
-}
-
 export type RustDocument = vscode.TextDocument & { languageId: "rust" };
 export type RustEditor = vscode.TextEditor & { document: RustDocument; id: string };
 
@@ -110,29 +82,3 @@ export function isRustDocument(document: vscode.TextDocument): document is RustD
 export function isRustEditor(editor: vscode.TextEditor): editor is RustEditor {
     return isRustDocument(editor.document);
 }
-
-/**
- * @param extensionId The canonical extension identifier in the form of: `publisher.name`
- */
-export async function vscodeReinstallExtension(extensionId: string) {
-    // Unfortunately there is no straightforward way as of now, these commands
-    // were found in vscode source code.
-
-    log.debug("Uninstalling extension", extensionId);
-    await vscode.commands.executeCommand("workbench.extensions.uninstallExtension", extensionId);
-    log.debug("Installing extension", extensionId);
-    await vscode.commands.executeCommand("workbench.extensions.installExtension", extensionId);
-}
-
-export async function vscodeReloadWindow(): Promise<never> {
-    await vscode.commands.executeCommand("workbench.action.reloadWindow");
-
-    assert(false, "unreachable");
-}
-
-export async function vscodeInstallExtensionFromVsix(vsixPath: string) {
-    await vscode.commands.executeCommand(
-        "workbench.extensions.installExtension",
-        vscode.Uri.file(vsixPath)
-    );
-}