Merge #2668

2668: In-server cargo check watching r=matklad a=kiljacken

Opening a draft now so people can follow the progress, and comment if they spot something stupid.

Things that need doing:
- [x] Running cargo check on save
- [x] Pipe through configuration options from client
- [x] Tests for parsing behavior
- [x] Remove existing cargo watch support from VSCode extension
- [x] Progress notification in VSCode extension using LSP 3.15 `$/progress` notification
- [ ] ~~Rework ra-ide diagnostics to support secondary messages~~
- [ ] ~~Make cargo-check watcher use ra-ide diagnostics~~

~~I'd love some input on whether to try to keep the status bar progress thingy for VSCode? It will require some plumbing, and maintaining yet another rust-analyzer specific LSP notification, which I'm not sure we want to.~~

Fixes #1894 

Co-authored-by: Emil Lauridsen <[email protected]>

1 files changed, 0 insertions, 67 deletions

diff --git a/editors/code/src/utils/diagnostics/SuggestedFix.ts b/editors/code/src/utils/diagnostics/SuggestedFix.ts
deleted file mode 100644
index 6e660bb61..000000000
--- a/editors/code/src/utils/diagnostics/SuggestedFix.ts
+++ /dev/null
@@ -1,67 +0,0 @@
-import * as vscode from 'vscode';
-
-import { SuggestionApplicability } from './rust';
-
-/**
- * Model object for text replacements suggested by the Rust compiler
- *
- * This is an intermediate form between the raw `rustc` JSON and a
- * `vscode.CodeAction`. It's optimised for the use-cases of
- * `SuggestedFixCollection`.
- */
-export default class SuggestedFix {
-    public readonly title: string;
-    public readonly location: vscode.Location;
-    public readonly replacement: string;
-    public readonly applicability: SuggestionApplicability;
-
-    /**
-     * Diagnostics this suggested fix could resolve
-     */
-    public diagnostics: vscode.Diagnostic[];
-
-    constructor(
-        title: string,
-        location: vscode.Location,
-        replacement: string,
-        applicability: SuggestionApplicability = SuggestionApplicability.Unspecified,
-    ) {
-        this.title = title;
-        this.location = location;
-        this.replacement = replacement;
-        this.applicability = applicability;
-        this.diagnostics = [];
-    }
-
-    /**
-     * Determines if this suggested fix is equivalent to another instance
-     */
-    public isEqual(other: SuggestedFix): boolean {
-        return (
-            this.title === other.title &&
-            this.location.range.isEqual(other.location.range) &&
-            this.replacement === other.replacement &&
-            this.applicability === other.applicability
-        );
-    }
-
-    /**
-     * Converts this suggested fix to a VS Code Quick Fix code action
-     */
-    public toCodeAction(): vscode.CodeAction {
-        const codeAction = new vscode.CodeAction(
-            this.title,
-            vscode.CodeActionKind.QuickFix,
-        );
-
-        const edit = new vscode.WorkspaceEdit();
-        edit.replace(this.location.uri, this.location.range, this.replacement);
-        codeAction.edit = edit;
-
-        codeAction.isPreferred =
-            this.applicability === SuggestionApplicability.MachineApplicable;
-
-        codeAction.diagnostics = [...this.diagnostics];
-        return codeAction;
-    }
-}