diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-07-23 10:51:40 +0100 |
|---|---|---|
| committer | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-07-23 10:51:40 +0100 |
| commit | 5f3ff157e3efe9f4fe2461bca1a0caaa5d2c72e5 (patch) | |
| tree | 38108566787198f9a1391cbf016b05016f3fbda0 /editors/code/src/utils/diagnostics/SuggestedFixCollection.ts | |
| parent | 08efe6cf92e7058ba38833dbfab8940a57a2cbfe (diff) | |
| parent | 8f3377d9f93a256f8e68ae183808fd767b529d18 (diff) | |
Merge #1549
1549: Show type lenses for the resolved let bindings r=matklad a=SomeoneToIgnore
Types that are fully unresolved are not displayed:
<img width="279" alt="image" src="https://user-images.githubusercontent.com/2690773/61518122-8e4ba980-aa11-11e9-9249-6d9f9b202e6a.png">
A few concerns that I have about the current implementation:
* I've adjusted the `file_structure` API method to return the information about the `let` bindings.
Although it works fine, I have a feeling that adding a new API method would be the better way.
But this requires some prior discussion, so I've decided to go for an easy way with an MVP.
Would be nice to hear your suggestions.
* There's a hardcoded `{undersolved}` check that I was forced to use, since the method that resolves types returns a `String`.
Is there a better typed API I can use? This will help, for instance, to add an action to the type lenses that will allow us to navigate to the type.
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'editors/code/src/utils/diagnostics/SuggestedFixCollection.ts')
0 files changed, 0 insertions, 0 deletions