aboutsummaryrefslogtreecommitdiff
path: root/editors/code/src
diff options
context:
space:
mode:
authorVeetaha <[email protected]>2020-08-21 20:12:22 +0100
committerVeetaha <[email protected]>2020-08-21 20:15:04 +0100
commit74ed42c8e9057bdd8910d0eba03ea0b30b87e660 (patch)
treefada52f7e8b78cd2ca69e63404bc7ac294d4fabf /editors/code/src
parentaab5aaccf2b1af8f1820a244a2c293c7460f9eb6 (diff)
Gate stream.pipeline workaround on fixed versions of node
Diffstat (limited to 'editors/code/src')
-rw-r--r--editors/code/src/net.ts8
1 files changed, 8 insertions, 0 deletions
diff --git a/editors/code/src/net.ts b/editors/code/src/net.ts
index 681eaa9c9..5eba2728d 100644
--- a/editors/code/src/net.ts
+++ b/editors/code/src/net.ts
@@ -134,6 +134,14 @@ async function downloadFile(
134 134
135 await pipeline(srcStream, destFileStream); 135 await pipeline(srcStream, destFileStream);
136 136
137 // Don't apply the workaround in fixed versions of nodejs, since the process
138 // freezes on them, the process waits for no-longer emitted `close` event.
139 // The fix was applied in commit 7eed9d6bcc in v13.11.0
140 // See the nodejs changelog:
141 // https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md
142 const [, major, minor] = /v(\d+)\.(\d+)\.(\d+)/.exec(process.version)!;
143 if (+major > 13 || (+major === 13 && +minor >= 11)) return;
144
137 await new Promise<void>(resolve => { 145 await new Promise<void>(resolve => {
138 destFileStream.on("close", resolve); 146 destFileStream.on("close", resolve);
139 destFileStream.destroy(); 147 destFileStream.destroy();