diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-02-11 09:07:23 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2020-02-11 09:07:23 +0000 |
commit | af9a9abbd8011d751e5d37f68c486336cb41ac65 (patch) | |
tree | 0923d4835008d023815bfb91b8609090f15420d5 /editors/code/src | |
parent | 6ac871b1df68070cf04085120d588efcb5c55986 (diff) | |
parent | 78ee964f7cb289d63be3a6d9573dc65b15c2fd2a (diff) |
Merge #3092
3092: vscode: fix binary is not functional on windows r=matklad a=Veetaha
This is my first approach to fix this error, need to double-check this on windows still...
Fixes #3087
Fixes #3090
Co-authored-by: Veetaha <[email protected]>
Diffstat (limited to 'editors/code/src')
-rw-r--r-- | editors/code/src/installation/download_file.ts | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/editors/code/src/installation/download_file.ts b/editors/code/src/installation/download_file.ts index b51602ef9..fe356c39d 100644 --- a/editors/code/src/installation/download_file.ts +++ b/editors/code/src/installation/download_file.ts | |||
@@ -27,8 +27,7 @@ export async function downloadFile( | |||
27 | readBytes += chunk.length; | 27 | readBytes += chunk.length; |
28 | onProgress(readBytes, totalBytes); | 28 | onProgress(readBytes, totalBytes); |
29 | }) | 29 | }) |
30 | .on("end", resolve) | ||
31 | .on("error", reject) | 30 | .on("error", reject) |
32 | .pipe(fs.createWriteStream(destFilePath)) | 31 | .pipe(fs.createWriteStream(destFilePath).on("close", resolve)) |
33 | ); | 32 | ); |
34 | } | 33 | } |