Merge #3072

3072: vscode: removed unnecessary awaits feature r=matklad a=Veetaha

Found a feature that when the user has no internet connection the whole extension is blocked by waiting for the user to dismiss the error message and for making a sanity-check dns resolution.

Co-authored-by: Veetaha <[email protected]>

1 files changed, 11 insertions, 5 deletions

diff --git a/editors/code/src/installation/language_server.ts b/editors/code/src/installation/language_server.ts
index 1ce67b8b2..3510f9178 100644
--- a/editors/code/src/installation/language_server.ts
+++ b/editors/code/src/installation/language_server.ts
@@ -100,15 +100,21 @@ export async function ensureLanguageServerBinary(
             try {
                 await downloadLatestLanguageServer(langServerSource);
             } catch (err) {
-                await vscode.window.showErrorMessage(
+                vscode.window.showErrorMessage(
                     `Failed to download language server from ${langServerSource.repo.name} ` +
                     `GitHub repository: ${err.message}`
                 );
 
-                await dns.resolve('www.google.com').catch(err => {
-                    console.error("DNS resolution failed, there might be an issue with Internet availability");
-                    console.error(err);
-                });
+                dns.resolve('example.com').then(
+                    addrs => console.log("DNS resolution for example.com was successful", addrs),
+                    err => {
+                        console.error(
+                            "DNS resolution for example.com failed, " +
+                            "there might be an issue with Internet availability"
+                        );
+                        console.error(err);
+                    }
+                );
 
                 return null;
             }