aboutsummaryrefslogtreecommitdiff
path: root/editors
diff options
context:
space:
mode:
authorarsdragonfly <[email protected]>2019-09-27 22:33:14 +0100
committerarsdragonfly <[email protected]>2019-09-27 22:33:14 +0100
commit945679e42fbefe565cb37456d3cf9cc3b0da6df5 (patch)
tree24be462aff4959fb7b6adb1b1577e85237119fd5 /editors
parent84340db87aed477f61bf46ba5e4a75f3eb672237 (diff)
Fix tests
Diffstat (limited to 'editors')
-rw-r--r--editors/code/src/test/utils/diagnotics/rust.test.ts8
-rw-r--r--editors/code/src/utils/diagnostics/rust.ts3
2 files changed, 5 insertions, 6 deletions
diff --git a/editors/code/src/test/utils/diagnotics/rust.test.ts b/editors/code/src/test/utils/diagnotics/rust.test.ts
index 7fb003fe2..327d15046 100644
--- a/editors/code/src/test/utils/diagnotics/rust.test.ts
+++ b/editors/code/src/test/utils/diagnotics/rust.test.ts
@@ -50,7 +50,7 @@ describe('mapRustDiagnosticToVsCode', () => {
50 ].join('\n') 50 ].join('\n')
51 ); 51 );
52 assert.strictEqual(diagnostic.code, 'E0053'); 52 assert.strictEqual(diagnostic.code, 'E0053');
53 assert.strictEqual(diagnostic.tags, undefined); 53 assert.deepStrictEqual(diagnostic.tags, []);
54 54
55 // No related information 55 // No related information
56 assert.deepStrictEqual(diagnostic.relatedInformation, []); 56 assert.deepStrictEqual(diagnostic.relatedInformation, []);
@@ -115,7 +115,7 @@ describe('mapRustDiagnosticToVsCode', () => {
115 ); 115 );
116 assert.strictEqual(diagnostic.code, 'E0061'); 116 assert.strictEqual(diagnostic.code, 'E0061');
117 assert.strictEqual(diagnostic.source, 'rustc'); 117 assert.strictEqual(diagnostic.source, 'rustc');
118 assert.strictEqual(diagnostic.tags, undefined); 118 assert.deepStrictEqual(diagnostic.tags, []);
119 119
120 // One related information for the original definition 120 // One related information for the original definition
121 const relatedInformation = diagnostic.relatedInformation; 121 const relatedInformation = diagnostic.relatedInformation;
@@ -149,7 +149,7 @@ describe('mapRustDiagnosticToVsCode', () => {
149 ].join('\n') 149 ].join('\n')
150 ); 150 );
151 assert.strictEqual(diagnostic.code, 'trivially_copy_pass_by_ref'); 151 assert.strictEqual(diagnostic.code, 'trivially_copy_pass_by_ref');
152 assert.strictEqual(diagnostic.tags, undefined); 152 assert.deepStrictEqual(diagnostic.tags, []);
153 153
154 // One related information for the lint definition 154 // One related information for the lint definition
155 const relatedInformation = diagnostic.relatedInformation; 155 const relatedInformation = diagnostic.relatedInformation;
@@ -189,7 +189,7 @@ describe('mapRustDiagnosticToVsCode', () => {
189 ); 189 );
190 assert.strictEqual(diagnostic.code, 'E0308'); 190 assert.strictEqual(diagnostic.code, 'E0308');
191 assert.strictEqual(diagnostic.source, 'rustc'); 191 assert.strictEqual(diagnostic.source, 'rustc');
192 assert.strictEqual(diagnostic.tags, undefined); 192 assert.deepStrictEqual(diagnostic.tags, []);
193 193
194 // No related information 194 // No related information
195 assert.deepStrictEqual(diagnostic.relatedInformation, []); 195 assert.deepStrictEqual(diagnostic.relatedInformation, []);
diff --git a/editors/code/src/utils/diagnostics/rust.ts b/editors/code/src/utils/diagnostics/rust.ts
index a66b52313..cd02ee46c 100644
--- a/editors/code/src/utils/diagnostics/rust.ts
+++ b/editors/code/src/utils/diagnostics/rust.ts
@@ -213,6 +213,7 @@ export function mapRustDiagnosticToVsCode(
213 vd.source = source; 213 vd.source = source;
214 vd.code = code; 214 vd.code = code;
215 vd.relatedInformation = []; 215 vd.relatedInformation = [];
216 vd.tags = [];
216 217
217 for (const secondarySpan of secondarySpans) { 218 for (const secondarySpan of secondarySpans) {
218 const related = mapSecondarySpanToRelated(secondarySpan); 219 const related = mapSecondarySpanToRelated(secondarySpan);
@@ -246,8 +247,6 @@ export function mapRustDiagnosticToVsCode(
246 vd.message += `\n${primarySpanLabel}`; 247 vd.message += `\n${primarySpanLabel}`;
247 } 248 }
248 249
249 vd.tags = []
250
251 if (isUnusedOrUnnecessary(rd)) { 250 if (isUnusedOrUnnecessary(rd)) {
252 vd.tags.push(vscode.DiagnosticTag.Unnecessary); 251 vd.tags.push(vscode.DiagnosticTag.Unnecessary);
253 } 252 }