diff options
author | Edwin Cheng <[email protected]> | 2019-04-02 10:13:14 +0100 |
---|---|---|
committer | Edwin Cheng <[email protected]> | 2019-04-02 10:13:14 +0100 |
commit | 9d269849987fbe374b0f76a4893fdf9d867b8b84 (patch) | |
tree | 5d5685228eab14976d9bd0e2205b466f9e70ed9a /editors | |
parent | 06053a0a7636b620d36d49678a5d73424e0010e9 (diff) |
Add terminate process implemntation note
Diffstat (limited to 'editors')
-rw-r--r-- | editors/code/src/utils/processes.ts | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/editors/code/src/utils/processes.ts b/editors/code/src/utils/processes.ts index d4c2c8778..f62e2a346 100644 --- a/editors/code/src/utils/processes.ts +++ b/editors/code/src/utils/processes.ts | |||
@@ -8,6 +8,13 @@ import { join } from 'path'; | |||
8 | const isWindows = process.platform === 'win32'; | 8 | const isWindows = process.platform === 'win32'; |
9 | const isMacintosh = process.platform === 'darwin'; | 9 | const isMacintosh = process.platform === 'darwin'; |
10 | const isLinux = process.platform === 'linux'; | 10 | const isLinux = process.platform === 'linux'; |
11 | |||
12 | // this is very complex, but is basically copy-pased from VSCode implementation here: | ||
13 | // https://github.com/Microsoft/vscode-languageserver-node/blob/dbfd37e35953ad0ee14c4eeced8cfbc41697b47e/client/src/utils/processes.ts#L15 | ||
14 | |||
15 | // And see discussion at | ||
16 | // https://github.com/rust-analyzer/rust-analyzer/pull/1079#issuecomment-478908109 | ||
17 | |||
11 | export function terminate(process: ChildProcess, cwd?: string): boolean { | 18 | export function terminate(process: ChildProcess, cwd?: string): boolean { |
12 | if (isWindows) { | 19 | if (isWindows) { |
13 | try { | 20 | try { |