diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-11-13 20:00:58 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2019-11-13 20:00:58 +0000 |
commit | e918b1f2b332e63e4918ca99503a812d1ce41ce0 (patch) | |
tree | c8e8d8f29011ad2b2472a201561f3f3dc1627d8f /xtask/Cargo.toml | |
parent | 619578304995fce4e99d8c42151fdb56d186ceeb (diff) | |
parent | 5075c77957e127be51e1b5271567f906abeb50c6 (diff) |
Merge #2232
2232: Use anyhow::Result in xtask, add contexts r=matklad a=killercup
This builds on #2231 but was actually done before that. You see, the
cause for #2231 was that I got this error message:
Error: Error { kind: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" }) }
Just switching to `anyhow::Result` got me stack traces (when setting
`RUST_LIB_BACKTRACE=1`) that at least showed
stack backtrace:
0: std::backtrace::Backtrace::create
1: std::backtrace::Backtrace::capture
2: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
3: xtask::install_server
4: xtask::install
5: xtask::main
6: std::rt::lang_start::{{closure}}
7: std::panicking::try::do_call
8: __rust_maybe_catch_panic
9: std::rt::lang_start_internal
10: std::rt::lang_start
11: main
With the added contexts (not at all exhaustive), the error became
Error: install server
Caused by:
0: build AutoCfg with target directory
1: No such file or directory (os error 2)
Since anyhow is such a small thing (no new transitive dependencies!),
and in general gives you `Result<T, Box<dyn Error>>` on steroids, I
think this a nice small change. The only slightly annoying thing was to
replace all the `Err(format!(…))?` calls (haven't even looked at whether
we can make it support wrapping strings though), but the `bail!` macro
is shorter anyway :)
Co-authored-by: Pascal Hertleif <[email protected]>
Diffstat (limited to 'xtask/Cargo.toml')
-rw-r--r-- | xtask/Cargo.toml | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/xtask/Cargo.toml b/xtask/Cargo.toml index 72b39c3b4..bba4be192 100644 --- a/xtask/Cargo.toml +++ b/xtask/Cargo.toml | |||
@@ -13,3 +13,4 @@ quote = "1.0.2" | |||
13 | proc-macro2 = "1.0.1" | 13 | proc-macro2 = "1.0.1" |
14 | ron = "0.5.1" | 14 | ron = "0.5.1" |
15 | serde = { version = "1.0.0", features = ["derive"] } | 15 | serde = { version = "1.0.0", features = ["derive"] } |
16 | anyhow = "1.0.19" | ||