diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-06-15 21:05:07 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-06-15 21:05:07 +0100 |
| commit | d0f2bc3b878d1c1d8eaf081e6f670ebb928b7a5f (patch) | |
| tree | d704be44422c3fe3981a43055a336141a88922c9 /xtask/src/codegen/gen_parser_tests.rs | |
| parent | dcea1c536c351a6063ba887813d54911a2b7eb39 (diff) | |
| parent | a6b0c056dedb17fa2056e5186bd73af66c5e84e3 (diff) | |
Merge #9292
9292: fix: Code: clean-up #8951 r=wxb1ank a=wxb1ank
#8951 was a major change in the VS Code extension and caused quite a few problems. This PR is a catch-all for bugs and improvements in the new code.
This should fix:
- #9284
- [this unreported bug](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446)
- ...and one or two uncaught exceptions I just found
The original lack of testing was my own fault, but this area of the VS Code API is also tricky for a couple reasons:
- The [FileSystem](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) API does not list or warn about any exceptions, but [FileSystemProvider](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) (which `FileSystem` is a wrapper of, AFAICT) does.
- At first glance, [Uri.path](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) *looks* like it works for FS operations. It does not, at least, on Windows. You need to use `Uri.fsPath`.
I only use Windows, so I need people on macOS, Linux, and (possibly) NixOS to test this.
Co-authored-by: wxb1ank <[email protected]>
Diffstat (limited to 'xtask/src/codegen/gen_parser_tests.rs')
0 files changed, 0 insertions, 0 deletions