diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-11-11 16:21:55 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-11-11 16:21:55 +0000 |
| commit | f742803c6a5a632af6e0aecb123920d1962e5fee (patch) | |
| tree | 1b0f7c7b0f430d4174ca05e5464b3af98128bafe /xtask/src/help.rs | |
| parent | a599147b4232c0d4f6b071a3a96e86f903f4cf52 (diff) | |
| parent | c5a18c44e5211282c22b9ca7aae8700ee8ca1817 (diff) | |
Merge #2213
2213: Hir generic param r=flodiebold a=matklad
r? @flodiebold
This should make the life of IDE easier: before, it got `GenericParam(u32)` which was of questionable utility. Now, it's a proper code_model type, so it can gain `source`, `name`, `module` and all the other hir methods, should the IDE need them. Moreover, IDE now doesn't care about internal representation of generic param, which seems like a long-term win.
The problem is, of course, that we now have to types named `GenericParam` in hir: this code_model type, and an internal type with an index which doesn't know about the parent. I think it's fine for the time being, but, after we finish cratefication of hir, this local `GenericParam` should move to `hir_def` or `hir_ty`, and *maybe* restrucured as `ParamId / PramData` pair.
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'xtask/src/help.rs')
0 files changed, 0 insertions, 0 deletions