diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-05-12 14:22:23 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2021-05-12 14:22:23 +0100 |
commit | a5b55828365b602f0ed117c9f1cc2a9eddd42512 (patch) | |
tree | 92c544276f4556e02c434321f2e0407d54d68a02 /xtask/src/release.rs | |
parent | 9a431c26f4528e2649de0ca171a38c93e473c94e (diff) | |
parent | a272cdfecdbbd95725d66b2452da3d379ef35d76 (diff) |
Merge #8812
8812: fix: fix dependencies of build scripts r=jonas-schievink a=jonas-schievink
Previously, we added a dependency for all targets in a package to the package's library target. This is correct for most targets, except build scripts, which run before the library crate is built. This PR removes the incorrect dependency on the library target.
We also used to treat all dependencies the same, which led to build scripts being able to use regular dependencies as well as dev-dependencies. This is also fixed by this PR, and build scripts only depend on build-dependencies.
Incorrect dependency graph:
![screenshot-2021-05-11-23:35:01](https://user-images.githubusercontent.com/1786438/117975228-c2066a80-b32e-11eb-8f01-1e3ea904a608.png)
Fixed graph after this PR:
![screenshot-2021-05-12-14:29:31](https://user-images.githubusercontent.com/1786438/117975253-c9c60f00-b32e-11eb-8f6c-9e42d4e32468.png)
Co-authored-by: Jonas Schievink <[email protected]>
Diffstat (limited to 'xtask/src/release.rs')
0 files changed, 0 insertions, 0 deletions