diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-04-24 17:05:16 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-04-24 17:05:16 +0100 |
| commit | 5d97667f8dd467e7382885fcae40bcdbac63ae4f (patch) | |
| tree | 5fd1a5271033937b50f78bcbb1b62a3ade027d33 /xtask/src | |
| parent | edd6f91cab77c4fabf449a50f4f65e4761c98ca4 (diff) | |
| parent | 0dab5d58790d46e28d738c0d1d96e833a61495a1 (diff) | |
Merge #4105
4105: Adds attribute completions (#3941) r=matklad a=jrvidal
I've hacked together some basic completions for a few builtin attributes.
* I have no idea what `CompletionItemKind` we should set for them.
* There's plenty of fancy stuff we could do by detecting the item the attribute is being added to. Nothing of that here.
* Maybe we could complete as soon as you type `#` or `#!`?
I'm not sure what info exactly we can dump on `CompletionContext` and what we should query during the completion calculation itself. I've assumed adding an `is_attribute` field is OK, since it allows to discard the completion quickly if it doesn't apply. Later we inspect the AST to find out whether it is an inner attribute or not.
Co-authored-by: Roberto Vidal <[email protected]>
Diffstat (limited to 'xtask/src')
0 files changed, 0 insertions, 0 deletions