Merge #7836

7836: Check for path dev-dependencies with a version number r=lnicola a=lnicola

Closes https://github.com/rust-analyzer/rust-analyzer/pull/7828#issuecomment-788174522.

This looks a bit ugly, but at least fixes an issues where we missed target-specific dependencies.

Co-authored-by: Laurențiu Nicola <[email protected]>

1 files changed, 33 insertions, 10 deletions

diff --git a/xtask/src/tidy.rs b/xtask/src/tidy.rs
index 63116ec6b..349ca14d0 100644
--- a/xtask/src/tidy.rs
+++ b/xtask/src/tidy.rs
@@ -101,21 +101,44 @@ fn cargo_files_are_tidy() {
         let mut section = None;
         for (line_no, text) in read_file(&cargo).unwrap().lines().enumerate() {
             let text = text.trim();
-            if text.starts_with("[") {
+            if text.starts_with('[') {
+                if !text.ends_with(']') {
+                    panic!(
+                        "\nplease don't add comments or trailing whitespace in section lines.\n\
+                            {}:{}\n",
+                        cargo.display(),
+                        line_no + 1
+                    )
+                }
                 section = Some(text);
                 continue;
             }
-            if !section.map(|it| it.starts_with("[dependencies")).unwrap_or(false) {
+            let text: String = text.split_whitespace().collect();
+            if !text.contains("path=") {
                 continue;
             }
-            let text: String = text.split_whitespace().collect();
-            if text.contains("path=") && !text.contains("version") {
-                panic!(
-                    "\ncargo internal dependencies should have version.\n\
-                     {}:{}\n",
-                    cargo.display(),
-                    line_no + 1
-                )
+            match section {
+                Some(s) if s.contains("dev-dependencies") => {
+                    if text.contains("version") {
+                        panic!(
+                            "\ncargo internal dev-dependencies should not have a version.\n\
+                            {}:{}\n",
+                            cargo.display(),
+                            line_no + 1
+                        );
+                    }
+                }
+                Some(s) if s.contains("dependencies") => {
+                    if !text.contains("version") {
+                        panic!(
+                            "\ncargo internal dependencies should have a version.\n\
+                            {}:{}\n",
+                            cargo.display(),
+                            line_no + 1
+                        );
+                    }
+                }
+                _ => {}
             }
         }
     }