diff options
author | Aleksey Kladov <[email protected]> | 2020-04-11 15:05:23 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-04-11 15:05:23 +0100 |
commit | 997c959d4f373df0cbba09609c5e4d8215d3d0c7 (patch) | |
tree | ddfeeaa144fe1621fc205dce5a9d18e2cd6f6455 /xtask | |
parent | 372414d27b41f60142f6c01fd48746a36e71f392 (diff) | |
parent | af04d45d32b5d9bdf949beb17152ef78dd4a0523 (diff) |
Merge pull request #3935 from cjhopman/todo
Change missing impl assist to use todo!() instead of unimplemented()
Diffstat (limited to 'xtask')
-rw-r--r-- | xtask/tests/tidy-tests/main.rs | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/xtask/tests/tidy-tests/main.rs b/xtask/tests/tidy-tests/main.rs index 80911a68e..4f525fcd0 100644 --- a/xtask/tests/tidy-tests/main.rs +++ b/xtask/tests/tidy-tests/main.rs | |||
@@ -20,7 +20,16 @@ fn rust_files_are_tidy() { | |||
20 | } | 20 | } |
21 | 21 | ||
22 | fn check_todo(path: &Path, text: &str) { | 22 | fn check_todo(path: &Path, text: &str) { |
23 | if path.ends_with("tests/cli.rs") { | 23 | let whitelist = &[ |
24 | // This file itself is whitelisted since this test itself contains matches. | ||
25 | "tests/cli.rs", | ||
26 | // Some of our assists generate `todo!()` so those files are whitelisted. | ||
27 | "doc_tests/generated.rs", | ||
28 | "handlers/add_missing_impl_members.rs", | ||
29 | // To support generating `todo!()` in assists, we have `expr_todo()` in ast::make. | ||
30 | "ast/make.rs", | ||
31 | ]; | ||
32 | if whitelist.iter().any(|p| path.ends_with(p)) { | ||
24 | return; | 33 | return; |
25 | } | 34 | } |
26 | if text.contains("TODO") || text.contains("TOOD") || text.contains("todo!") { | 35 | if text.contains("TODO") || text.contains("TOOD") || text.contains("todo!") { |