diff options
-rw-r--r-- | docs/dev/architecture.md | 6 | ||||
-rw-r--r-- | docs/dev/style.md | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/docs/dev/architecture.md b/docs/dev/architecture.md index 081ee5b9d..ead12616e 100644 --- a/docs/dev/architecture.md +++ b/docs/dev/architecture.md | |||
@@ -209,7 +209,7 @@ If you want to use IDE parts of rust-analyzer via LSP, custom flatbuffers-based | |||
209 | The API uses editor's terminology, it talks about offsets and string labels rather than in terms of definitions or types. | 209 | The API uses editor's terminology, it talks about offsets and string labels rather than in terms of definitions or types. |
210 | It is effectively the view in MVC and viewmodel in [MVVM](https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93viewmodel). | 210 | It is effectively the view in MVC and viewmodel in [MVVM](https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93viewmodel). |
211 | All arguments and return types are conceptually serializable. | 211 | All arguments and return types are conceptually serializable. |
212 | In particular, syntax tress and and hir types are generally absent from the API (but are used heavily in the implementation). | 212 | In particular, syntax tress and hir types are generally absent from the API (but are used heavily in the implementation). |
213 | Shout outs to LSP developers for popularizing the idea that "UI" is a good place to draw a boundary at. | 213 | Shout outs to LSP developers for popularizing the idea that "UI" is a good place to draw a boundary at. |
214 | 214 | ||
215 | `ide` is also the first crate which has the notion of change over time. | 215 | `ide` is also the first crate which has the notion of change over time. |
@@ -230,7 +230,7 @@ This crate defines the `rust-analyzer` binary, so it is the **entry point**. | |||
230 | It implements the language server. | 230 | It implements the language server. |
231 | 231 | ||
232 | **Architecture Invariant:** `rust-analyzer` is the only crate that knows about LSP and JSON serialization. | 232 | **Architecture Invariant:** `rust-analyzer` is the only crate that knows about LSP and JSON serialization. |
233 | If you want to expose a datastructure `X` from ide to LSP, don't make it serializable. | 233 | If you want to expose a data structure `X` from ide to LSP, don't make it serializable. |
234 | Instead, create a serializable counterpart in `rust-analyzer` crate and manually convert between the two. | 234 | Instead, create a serializable counterpart in `rust-analyzer` crate and manually convert between the two. |
235 | 235 | ||
236 | `GlobalState` is the state of the server. | 236 | `GlobalState` is the state of the server. |
@@ -418,7 +418,7 @@ We use `always` and `never` macros instead of `assert` to gracefully recover fro | |||
418 | 418 | ||
419 | ### Observability | 419 | ### Observability |
420 | 420 | ||
421 | rust-analyzer is a long-running process, so its important to understand what's going on inside. | 421 | rust-analyzer is a long-running process, so it is important to understand what's going on inside. |
422 | We have several instruments for that. | 422 | We have several instruments for that. |
423 | 423 | ||
424 | The event loop that runs rust-analyzer is very explicit. | 424 | The event loop that runs rust-analyzer is very explicit. |
diff --git a/docs/dev/style.md b/docs/dev/style.md index 73ce59b87..dd71e3932 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
@@ -41,7 +41,7 @@ For the second group, the change would be subjected to quite a bit of scrutiny a | |||
41 | The new API needs to be right (or at least easy to change later). | 41 | The new API needs to be right (or at least easy to change later). |
42 | The actual implementation doesn't matter that much. | 42 | The actual implementation doesn't matter that much. |
43 | It's very important to minimize the amount of changed lines of code for changes of the second kind. | 43 | It's very important to minimize the amount of changed lines of code for changes of the second kind. |
44 | Often, you start doing a change of the first kind, only to realise that you need to elevate to a change of the second kind. | 44 | Often, you start doing a change of the first kind, only to realize that you need to elevate to a change of the second kind. |
45 | In this case, we'll probably ask you to split API changes into a separate PR. | 45 | In this case, we'll probably ask you to split API changes into a separate PR. |
46 | 46 | ||
47 | Changes of the third group should be pretty rare, so we don't specify any specific process for them. | 47 | Changes of the third group should be pretty rare, so we don't specify any specific process for them. |
@@ -102,7 +102,7 @@ Of course, applying Clippy suggestions is welcome as long as they indeed improve | |||
102 | ## Minimal Tests | 102 | ## Minimal Tests |
103 | 103 | ||
104 | Most tests in rust-analyzer start with a snippet of Rust code. | 104 | Most tests in rust-analyzer start with a snippet of Rust code. |
105 | This snippets should be minimal -- if you copy-paste a snippet of real code into the tests, make sure to remove everything which could be removed. | 105 | These snippets should be minimal -- if you copy-paste a snippet of real code into the tests, make sure to remove everything which could be removed. |
106 | 106 | ||
107 | It also makes sense to format snippets more compactly (for example, by placing enum definitions like `enum E { Foo, Bar }` on a single line), | 107 | It also makes sense to format snippets more compactly (for example, by placing enum definitions like `enum E { Foo, Bar }` on a single line), |
108 | as long as they are still readable. | 108 | as long as they are still readable. |
@@ -227,7 +227,7 @@ if idx >= len { | |||
227 | } | 227 | } |
228 | ``` | 228 | ``` |
229 | 229 | ||
230 | **Rationale:** its useful to see the invariant relied upon by the rest of the function clearly spelled out. | 230 | **Rationale:** it's useful to see the invariant relied upon by the rest of the function clearly spelled out. |
231 | 231 | ||
232 | ## Assertions | 232 | ## Assertions |
233 | 233 | ||