diff options
Diffstat (limited to 'crates/hir_def/src')
-rw-r--r-- | crates/hir_def/src/body/lower.rs | 22 | ||||
-rw-r--r-- | crates/hir_def/src/expr.rs | 14 | ||||
-rw-r--r-- | crates/hir_def/src/path.rs | 6 |
3 files changed, 26 insertions, 16 deletions
diff --git a/crates/hir_def/src/body/lower.rs b/crates/hir_def/src/body/lower.rs index 63e89a1f4..1e743e5d5 100644 --- a/crates/hir_def/src/body/lower.rs +++ b/crates/hir_def/src/body/lower.rs | |||
@@ -322,8 +322,10 @@ impl ExprCollector<'_> { | |||
322 | Vec::new() | 322 | Vec::new() |
323 | }; | 323 | }; |
324 | let method_name = e.name_ref().map(|nr| nr.as_name()).unwrap_or_else(Name::missing); | 324 | let method_name = e.name_ref().map(|nr| nr.as_name()).unwrap_or_else(Name::missing); |
325 | let generic_args = | 325 | let generic_args = e |
326 | e.generic_arg_list().and_then(|it| GenericArgs::from_ast(&self.ctx(), it)); | 326 | .generic_arg_list() |
327 | .and_then(|it| GenericArgs::from_ast(&self.ctx(), it)) | ||
328 | .map(Box::new); | ||
327 | self.alloc_expr( | 329 | self.alloc_expr( |
328 | Expr::MethodCall { receiver, method_name, args, generic_args }, | 330 | Expr::MethodCall { receiver, method_name, args, generic_args }, |
329 | syntax_ptr, | 331 | syntax_ptr, |
@@ -385,7 +387,7 @@ impl ExprCollector<'_> { | |||
385 | self.alloc_expr(Expr::Yield { expr }, syntax_ptr) | 387 | self.alloc_expr(Expr::Yield { expr }, syntax_ptr) |
386 | } | 388 | } |
387 | ast::Expr::RecordExpr(e) => { | 389 | ast::Expr::RecordExpr(e) => { |
388 | let path = e.path().and_then(|path| self.expander.parse_path(path)); | 390 | let path = e.path().and_then(|path| self.expander.parse_path(path)).map(Box::new); |
389 | let record_lit = if let Some(nfl) = e.record_expr_field_list() { | 391 | let record_lit = if let Some(nfl) = e.record_expr_field_list() { |
390 | let fields = nfl | 392 | let fields = nfl |
391 | .fields() | 393 | .fields() |
@@ -430,7 +432,7 @@ impl ExprCollector<'_> { | |||
430 | } | 432 | } |
431 | ast::Expr::CastExpr(e) => { | 433 | ast::Expr::CastExpr(e) => { |
432 | let expr = self.collect_expr_opt(e.expr()); | 434 | let expr = self.collect_expr_opt(e.expr()); |
433 | let type_ref = TypeRef::from_ast_opt(&self.ctx(), e.ty()); | 435 | let type_ref = Box::new(TypeRef::from_ast_opt(&self.ctx(), e.ty())); |
434 | self.alloc_expr(Expr::Cast { expr, type_ref }, syntax_ptr) | 436 | self.alloc_expr(Expr::Cast { expr, type_ref }, syntax_ptr) |
435 | } | 437 | } |
436 | ast::Expr::RefExpr(e) => { | 438 | ast::Expr::RefExpr(e) => { |
@@ -469,8 +471,10 @@ impl ExprCollector<'_> { | |||
469 | arg_types.push(type_ref); | 471 | arg_types.push(type_ref); |
470 | } | 472 | } |
471 | } | 473 | } |
472 | let ret_type = | 474 | let ret_type = e |
473 | e.ret_type().and_then(|r| r.ty()).map(|it| TypeRef::from_ast(&self.ctx(), it)); | 475 | .ret_type() |
476 | .and_then(|r| r.ty()) | ||
477 | .map(|it| Box::new(TypeRef::from_ast(&self.ctx(), it))); | ||
474 | let body = self.collect_expr_opt(e.body()); | 478 | let body = self.collect_expr_opt(e.body()); |
475 | self.alloc_expr(Expr::Lambda { args, arg_types, ret_type, body }, syntax_ptr) | 479 | self.alloc_expr(Expr::Lambda { args, arg_types, ret_type, body }, syntax_ptr) |
476 | } | 480 | } |
@@ -755,7 +759,7 @@ impl ExprCollector<'_> { | |||
755 | } | 759 | } |
756 | } | 760 | } |
757 | ast::Pat::TupleStructPat(p) => { | 761 | ast::Pat::TupleStructPat(p) => { |
758 | let path = p.path().and_then(|path| self.expander.parse_path(path)); | 762 | let path = p.path().and_then(|path| self.expander.parse_path(path)).map(Box::new); |
759 | let (args, ellipsis) = self.collect_tuple_pat(p.fields()); | 763 | let (args, ellipsis) = self.collect_tuple_pat(p.fields()); |
760 | Pat::TupleStruct { path, args, ellipsis } | 764 | Pat::TupleStruct { path, args, ellipsis } |
761 | } | 765 | } |
@@ -765,7 +769,7 @@ impl ExprCollector<'_> { | |||
765 | Pat::Ref { pat, mutability } | 769 | Pat::Ref { pat, mutability } |
766 | } | 770 | } |
767 | ast::Pat::PathPat(p) => { | 771 | ast::Pat::PathPat(p) => { |
768 | let path = p.path().and_then(|path| self.expander.parse_path(path)); | 772 | let path = p.path().and_then(|path| self.expander.parse_path(path)).map(Box::new); |
769 | path.map(Pat::Path).unwrap_or(Pat::Missing) | 773 | path.map(Pat::Path).unwrap_or(Pat::Missing) |
770 | } | 774 | } |
771 | ast::Pat::OrPat(p) => { | 775 | ast::Pat::OrPat(p) => { |
@@ -779,7 +783,7 @@ impl ExprCollector<'_> { | |||
779 | } | 783 | } |
780 | ast::Pat::WildcardPat(_) => Pat::Wild, | 784 | ast::Pat::WildcardPat(_) => Pat::Wild, |
781 | ast::Pat::RecordPat(p) => { | 785 | ast::Pat::RecordPat(p) => { |
782 | let path = p.path().and_then(|path| self.expander.parse_path(path)); | 786 | let path = p.path().and_then(|path| self.expander.parse_path(path)).map(Box::new); |
783 | let args: Vec<_> = p | 787 | let args: Vec<_> = p |
784 | .record_pat_field_list() | 788 | .record_pat_field_list() |
785 | .expect("every struct should have a field list") | 789 | .expect("every struct should have a field list") |
diff --git a/crates/hir_def/src/expr.rs b/crates/hir_def/src/expr.rs index 6c7376fad..62a28bdba 100644 --- a/crates/hir_def/src/expr.rs +++ b/crates/hir_def/src/expr.rs | |||
@@ -86,7 +86,7 @@ pub enum Expr { | |||
86 | receiver: ExprId, | 86 | receiver: ExprId, |
87 | method_name: Name, | 87 | method_name: Name, |
88 | args: Vec<ExprId>, | 88 | args: Vec<ExprId>, |
89 | generic_args: Option<GenericArgs>, | 89 | generic_args: Option<Box<GenericArgs>>, |
90 | }, | 90 | }, |
91 | Match { | 91 | Match { |
92 | expr: ExprId, | 92 | expr: ExprId, |
@@ -106,7 +106,7 @@ pub enum Expr { | |||
106 | expr: Option<ExprId>, | 106 | expr: Option<ExprId>, |
107 | }, | 107 | }, |
108 | RecordLit { | 108 | RecordLit { |
109 | path: Option<Path>, | 109 | path: Option<Box<Path>>, |
110 | fields: Vec<RecordLitField>, | 110 | fields: Vec<RecordLitField>, |
111 | spread: Option<ExprId>, | 111 | spread: Option<ExprId>, |
112 | }, | 112 | }, |
@@ -131,7 +131,7 @@ pub enum Expr { | |||
131 | }, | 131 | }, |
132 | Cast { | 132 | Cast { |
133 | expr: ExprId, | 133 | expr: ExprId, |
134 | type_ref: TypeRef, | 134 | type_ref: Box<TypeRef>, |
135 | }, | 135 | }, |
136 | Ref { | 136 | Ref { |
137 | expr: ExprId, | 137 | expr: ExprId, |
@@ -162,7 +162,7 @@ pub enum Expr { | |||
162 | Lambda { | 162 | Lambda { |
163 | args: Vec<PatId>, | 163 | args: Vec<PatId>, |
164 | arg_types: Vec<Option<TypeRef>>, | 164 | arg_types: Vec<Option<TypeRef>>, |
165 | ret_type: Option<TypeRef>, | 165 | ret_type: Option<Box<TypeRef>>, |
166 | body: ExprId, | 166 | body: ExprId, |
167 | }, | 167 | }, |
168 | Tuple { | 168 | Tuple { |
@@ -412,13 +412,13 @@ pub enum Pat { | |||
412 | Wild, | 412 | Wild, |
413 | Tuple { args: Vec<PatId>, ellipsis: Option<usize> }, | 413 | Tuple { args: Vec<PatId>, ellipsis: Option<usize> }, |
414 | Or(Vec<PatId>), | 414 | Or(Vec<PatId>), |
415 | Record { path: Option<Path>, args: Vec<RecordFieldPat>, ellipsis: bool }, | 415 | Record { path: Option<Box<Path>>, args: Vec<RecordFieldPat>, ellipsis: bool }, |
416 | Range { start: ExprId, end: ExprId }, | 416 | Range { start: ExprId, end: ExprId }, |
417 | Slice { prefix: Vec<PatId>, slice: Option<PatId>, suffix: Vec<PatId> }, | 417 | Slice { prefix: Vec<PatId>, slice: Option<PatId>, suffix: Vec<PatId> }, |
418 | Path(Path), | 418 | Path(Box<Path>), |
419 | Lit(ExprId), | 419 | Lit(ExprId), |
420 | Bind { mode: BindingAnnotation, name: Name, subpat: Option<PatId> }, | 420 | Bind { mode: BindingAnnotation, name: Name, subpat: Option<PatId> }, |
421 | TupleStruct { path: Option<Path>, args: Vec<PatId>, ellipsis: Option<usize> }, | 421 | TupleStruct { path: Option<Box<Path>>, args: Vec<PatId>, ellipsis: Option<usize> }, |
422 | Ref { pat: PatId, mutability: Mutability }, | 422 | Ref { pat: PatId, mutability: Mutability }, |
423 | Box { inner: PatId }, | 423 | Box { inner: PatId }, |
424 | ConstBlock(ExprId), | 424 | ConstBlock(ExprId), |
diff --git a/crates/hir_def/src/path.rs b/crates/hir_def/src/path.rs index f9c8328f0..b528ff8ba 100644 --- a/crates/hir_def/src/path.rs +++ b/crates/hir_def/src/path.rs | |||
@@ -289,6 +289,12 @@ impl From<Name> for Path { | |||
289 | } | 289 | } |
290 | } | 290 | } |
291 | 291 | ||
292 | impl From<Name> for Box<Path> { | ||
293 | fn from(name: Name) -> Box<Path> { | ||
294 | Box::new(Path::from(name)) | ||
295 | } | ||
296 | } | ||
297 | |||
292 | impl From<Name> for ModPath { | 298 | impl From<Name> for ModPath { |
293 | fn from(name: Name) -> ModPath { | 299 | fn from(name: Name) -> ModPath { |
294 | ModPath::from_segments(PathKind::Plain, iter::once(name)) | 300 | ModPath::from_segments(PathKind::Plain, iter::once(name)) |