aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_project_model/src
diff options
context:
space:
mode:
Diffstat (limited to 'crates/ra_project_model/src')
-rw-r--r--crates/ra_project_model/src/cargo_workspace.rs7
-rw-r--r--crates/ra_project_model/src/lib.rs4
-rw-r--r--crates/ra_project_model/src/sysroot.rs6
3 files changed, 7 insertions, 10 deletions
diff --git a/crates/ra_project_model/src/cargo_workspace.rs b/crates/ra_project_model/src/cargo_workspace.rs
index f3e67d0e5..8adf463a6 100644
--- a/crates/ra_project_model/src/cargo_workspace.rs
+++ b/crates/ra_project_model/src/cargo_workspace.rs
@@ -1,7 +1,6 @@
1use std::path::{Path, PathBuf}; 1use std::path::{Path, PathBuf};
2 2
3use cargo_metadata::{MetadataCommand, CargoOpt}; 3use cargo_metadata::{MetadataCommand, CargoOpt};
4use smol_str::SmolStr;
5use ra_arena::{Arena, RawId, impl_arena_id}; 4use ra_arena::{Arena, RawId, impl_arena_id};
6use rustc_hash::FxHashMap; 5use rustc_hash::FxHashMap;
7use failure::format_err; 6use failure::format_err;
@@ -31,7 +30,7 @@ impl_arena_id!(Target);
31 30
32#[derive(Debug, Clone)] 31#[derive(Debug, Clone)]
33struct PackageData { 32struct PackageData {
34 name: SmolStr, 33 name: String,
35 manifest: PathBuf, 34 manifest: PathBuf,
36 targets: Vec<Target>, 35 targets: Vec<Target>,
37 is_member: bool, 36 is_member: bool,
@@ -41,13 +40,13 @@ struct PackageData {
41#[derive(Debug, Clone)] 40#[derive(Debug, Clone)]
42pub struct PackageDependency { 41pub struct PackageDependency {
43 pub pkg: Package, 42 pub pkg: Package,
44 pub name: SmolStr, 43 pub name: String,
45} 44}
46 45
47#[derive(Debug, Clone)] 46#[derive(Debug, Clone)]
48struct TargetData { 47struct TargetData {
49 pkg: Package, 48 pkg: Package,
50 name: SmolStr, 49 name: String,
51 root: PathBuf, 50 root: PathBuf,
52 kind: TargetKind, 51 kind: TargetKind,
53} 52}
diff --git a/crates/ra_project_model/src/lib.rs b/crates/ra_project_model/src/lib.rs
index 30612ac84..abc79684c 100644
--- a/crates/ra_project_model/src/lib.rs
+++ b/crates/ra_project_model/src/lib.rs
@@ -47,7 +47,7 @@ impl ProjectWorkspace {
47 if let (Some(&from), Some(&to)) = 47 if let (Some(&from), Some(&to)) =
48 (sysroot_crates.get(&from), sysroot_crates.get(&to)) 48 (sysroot_crates.get(&from), sysroot_crates.get(&to))
49 { 49 {
50 if let Err(_) = crate_graph.add_dep(from, name.clone(), to) { 50 if let Err(_) = crate_graph.add_dep(from, name.into(), to) {
51 log::error!("cyclic dependency between sysroot crates") 51 log::error!("cyclic dependency between sysroot crates")
52 } 52 }
53 } 53 }
@@ -101,7 +101,7 @@ impl ProjectWorkspace {
101 for dep in pkg.dependencies(&self.cargo) { 101 for dep in pkg.dependencies(&self.cargo) {
102 if let Some(&to) = pkg_to_lib_crate.get(&dep.pkg) { 102 if let Some(&to) = pkg_to_lib_crate.get(&dep.pkg) {
103 for &from in pkg_crates.get(&pkg).into_iter().flatten() { 103 for &from in pkg_crates.get(&pkg).into_iter().flatten() {
104 if let Err(_) = crate_graph.add_dep(from, dep.name.clone(), to) { 104 if let Err(_) = crate_graph.add_dep(from, dep.name.clone().into(), to) {
105 log::error!( 105 log::error!(
106 "cyclic dependency {} -> {}", 106 "cyclic dependency {} -> {}",
107 pkg.name(&self.cargo), 107 pkg.name(&self.cargo),
diff --git a/crates/ra_project_model/src/sysroot.rs b/crates/ra_project_model/src/sysroot.rs
index 18824dbe5..8b87aa7bd 100644
--- a/crates/ra_project_model/src/sysroot.rs
+++ b/crates/ra_project_model/src/sysroot.rs
@@ -3,8 +3,6 @@ use std::{
3 process::Command, 3 process::Command,
4}; 4};
5 5
6use smol_str::SmolStr;
7
8use ra_arena::{Arena, RawId, impl_arena_id}; 6use ra_arena::{Arena, RawId, impl_arena_id};
9 7
10use crate::Result; 8use crate::Result;
@@ -20,7 +18,7 @@ impl_arena_id!(SysrootCrate);
20 18
21#[derive(Debug, Clone)] 19#[derive(Debug, Clone)]
22struct SysrootCrateData { 20struct SysrootCrateData {
23 name: SmolStr, 21 name: String,
24 root: PathBuf, 22 root: PathBuf,
25 deps: Vec<SysrootCrate>, 23 deps: Vec<SysrootCrate>,
26} 24}
@@ -81,7 +79,7 @@ impl Sysroot {
81} 79}
82 80
83impl SysrootCrate { 81impl SysrootCrate {
84 pub fn name(self, sysroot: &Sysroot) -> &SmolStr { 82 pub fn name(self, sysroot: &Sysroot) -> &str {
85 &sysroot.crates[self].name 83 &sysroot.crates[self].name
86 } 84 }
87 pub fn root(self, sysroot: &Sysroot) -> &Path { 85 pub fn root(self, sysroot: &Sysroot) -> &Path {