diff options
Diffstat (limited to 'docs/dev')
-rw-r--r-- | docs/dev/lsp-extensions.md | 6 | ||||
-rw-r--r-- | docs/dev/style.md | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/docs/dev/lsp-extensions.md b/docs/dev/lsp-extensions.md index a46121bb2..a4d92242b 100644 --- a/docs/dev/lsp-extensions.md +++ b/docs/dev/lsp-extensions.md | |||
@@ -1,8 +1,8 @@ | |||
1 | <!--- | 1 | <!--- |
2 | lsp_ext.rs hash: faae991334a151d0 | 2 | lsp_ext.rs hash: b19ddc3ab8767af9 |
3 | 3 | ||
4 | If you need to change the above hash to make the test pass, please check if you | 4 | If you need to change the above hash to make the test pass, please check if you |
5 | need to adjust this doc as well and ping this issue: | 5 | need to adjust this doc as well and ping this issue: |
6 | 6 | ||
7 | https://github.com/rust-analyzer/rust-analyzer/issues/4604 | 7 | https://github.com/rust-analyzer/rust-analyzer/issues/4604 |
8 | 8 | ||
@@ -620,7 +620,7 @@ This request is sent from client to server to move item under cursor or selectio | |||
620 | 620 | ||
621 | **Request:** `MoveItemParams` | 621 | **Request:** `MoveItemParams` |
622 | 622 | ||
623 | **Response:** `TextDocumentEdit | null` | 623 | **Response:** `SnippetTextEdit[]` |
624 | 624 | ||
625 | ```typescript | 625 | ```typescript |
626 | export interface MoveItemParams { | 626 | export interface MoveItemParams { |
diff --git a/docs/dev/style.md b/docs/dev/style.md index 7c47c26b2..078c478d4 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
@@ -159,7 +159,7 @@ More than one mark per test / code branch doesn't add significantly to understan | |||
159 | Do not use `#[should_panic]` tests. | 159 | Do not use `#[should_panic]` tests. |
160 | Instead, explicitly check for `None`, `Err`, etc. | 160 | Instead, explicitly check for `None`, `Err`, etc. |
161 | 161 | ||
162 | **Rationale:**a `#[should_panic]` is a tool for library authors, to makes sure that API does not fail silently, when misused. | 162 | **Rationale:** `#[should_panic]` is a tool for library authors, to makes sure that API does not fail silently, when misused. |
163 | `rust-analyzer` is not a library, we don't need to test for API misuse, and we have to handle any user input without panics. | 163 | `rust-analyzer` is not a library, we don't need to test for API misuse, and we have to handle any user input without panics. |
164 | Panic messages in the logs from the `#[should_panic]` tests are confusing. | 164 | Panic messages in the logs from the `#[should_panic]` tests are confusing. |
165 | 165 | ||