aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #8660bors[bot]2021-04-262-4/+9
|\ | | | | | | | | | | | | | | 8660: Added `mutable` semantic token modifier for `&mut self` methods r=Veykril a=1c3t3a This closes #8644. Co-authored-by: Bastian Kersting <[email protected]>
| * Fixed formattingBastian Kersting2021-04-261-1/+1
| |
| * Added mutable semantic token modifier for &mut self methodsBastian Kersting2021-04-262-4/+9
|/
* Merge #8658bors[bot]2021-04-252-6/+105
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 8658: Check more carefully for cases where a rename can't be done r=Veykril a=dzhu Attempting to rename an element of a tuple field would previously replace the type with the new name, which doesn't make sense; now it fails instead. The check is done in both `prepare_rename` and `rename` so that the case is caught before the user is prompted for a new name. Some other existing failure cases are also now additionally checked in `prepare_rename`. Closes: #8592 (I threw in some doc edits for a relevant type; of course, I can remove those if the policy here is to be strict about scope of changes within a PR.) Co-authored-by: Danny Zhu <[email protected]>
| * Check more carefully for cases where a rename can't be doneDanny Zhu2021-04-252-6/+105
| | | | | | | | | | | | | | | | | | | | | | Attempting to rename an element of a tuple field would previously replace the type with the new name, which doesn't make sense; now it fails instead. The check is done in both `prepare_rename` and `rename` so that the case is caught before the user is prompted for a new name. Some other existing failure cases are also now additionally checked in `prepare_rename`.
* | Merge #8656bors[bot]2021-04-251-4/+4
|\ \ | |/ |/| | | | | | | | | | | 8656: Update deps r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * Update depsJeremy Kolb2021-04-251-4/+4
|/
* Merge #8647bors[bot]2021-04-248-329/+344
|\ | | | | | | | | | | | | | | 8647: internal: Split out merge_imports module from helpers::insert_use r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * Split out merge_imports module from helpers::insert_useLukas Wirth2021-04-248-329/+344
|/
* Merge #8643bors[bot]2021-04-242-24/+46
|\ | | | | | | | | | | | | | | | | 8643: fix: correct version string to contain hash, build date and channel r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * fix: correct version string to contain hash, build date and channelAleksey Kladov2021-04-242-24/+46
|/
* minorAleksey Kladov2021-04-241-1/+1
|
* Merge #8641bors[bot]2021-04-241-1/+1
|\ | | | | | | | | | | | | | | | | 8641: minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * minorAleksey Kladov2021-04-241-1/+1
| |
* | Merge #8639bors[bot]2021-04-231-1/+3
|\| | | | | | | | | | | | | | | | | 8639: fix: 'configuration.property' error in VS Code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * fix: 'configuration.property' error in VS CodeAleksey Kladov2021-04-231-1/+3
| | | | | | | | closes #7789
| |
| \
*-. \ Merge #8591 #8638bors[bot]2021-04-2315-355/+331
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8591: Remove SyntaxRewriter usage in insert_use in favor of mutable syntax trees r=matklad a=Veykril Unfortunately changing `insert_use` to not use `SyntaxRewriter` creates a lot of changes since so much relies on that. But on the other hand this should be the biggest usage of `SyntaxRewriter` I believe. 8638: Remove SyntaxRewriter::from_fn r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| | * Remove SyntaxRewriter::from_fnLukas Wirth2021-04-233-31/+24
| |/ |/|
* | Merge #8637bors[bot]2021-04-237-150/+147
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 8637: Tag `yield` and `await` as ControlFlow in semantic highlighting r=Veykril a=Veykril and shuffle some code around Closes #8634 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Simplify highlight token match guardsLukas Wirth2021-04-232-102/+92
| | |
| * | Sort HlMod variants and ALL constLukas Wirth2021-04-236-46/+45
| | |
| * | Tag `yield` and `await` as ControlFlow in semantic highlightingLukas Wirth2021-04-232-5/+13
|/ /
* | Merge #8317bors[bot]2021-04-235-7/+636
|\ \ | | | | | | | | | | | | | | | | | | | | | 8317: Convert tuple struct to named struct assist r=Veykril a=unexge Closes https://github.com/rust-analyzer/rust-analyzer/issues/8192 Co-authored-by: unexge <[email protected]>
| * | Add missing test case for "Convert to named struct" assistunexge2021-04-231-0/+40
| | |
| * | Stop iterating reference after made an edit in "Convert to named struct" assistunexge2021-04-231-2/+47
| | |
| * | Move reference editing logic into own function to make error handling more ↵unexge2021-04-221-68/+61
| | | | | | | | | | | | ease in "Convert to named struct" assist
| * | Use multiple loops instead of `Iterator::chain` in `FindUsages`unexge2021-04-211-13/+22
| | |
| * | Add multi file test for "Convert to named struct" assistunexge2021-04-211-0/+33
| | |
| * | Remove `unwrap`s in "Convert to named struct" assistunexge2021-04-211-9/+19
| | |
| * | Add larger example for "Convert to named struct" assistunexge2021-04-212-8/+60
| | |
| * | Fix incorrectly replacing method calls in "Convert to named struct" assistunexge2021-04-211-17/+41
| | |
| * | Add convert tuple struct to named struct assistunexge2021-04-045-9/+397
| | |
| * | Allow including `Self` kw references to `FindUsages`unexge2021-04-041-4/+39
| | |
* | | Merge #8628bors[bot]2021-04-221-0/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8628: minor: Add one more profiling span to add_dep r=lnicola a=lnicola CC #8623 bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Add one more profiling span to add_depLaurențiu Nicola2021-04-221-0/+1
| | | |
* | | | Merge #8627bors[bot]2021-04-224-3/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8627: Add profiling spans under cargo_to_crate_graph r=lnicola a=lnicola bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Add profiling spans under cargo_to_crate_graphLaurențiu Nicola2021-04-224-3/+7
| | | |
* | | | Merge #8605bors[bot]2021-04-223-43/+173
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8605: internal: Automatically categorize the changelog entries r=matklad a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | Automatically categorize the changelog entriesLaurențiu Nicola2021-04-203-43/+173
| | | | |
* | | | | Merge #8620bors[bot]2021-04-221-14/+22
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8620: Remove unnecessary braces for extracted block expression r=Veykril a=brandondong This change addresses the first bullet point of https://github.com/rust-analyzer/rust-analyzer/issues/7839. Specifically, when extracting block expressions, remove the unneeded extra braces inside the generated function. Co-authored-by: Brandon <[email protected]>
| * | | | | Remove unnecessary braces for extracted block expressionBrandon2021-04-221-14/+22
| | | | | |
* | | | | | Merge #8621bors[bot]2021-04-222-0/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8621: feat: make sure nightly regressions don't break users r=lnicola a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | feat: make sure nightly regressions don't break usersAleksey Kladov2021-04-222-0/+21
| | | | | | |
* | | | | | | Merge #8595bors[bot]2021-04-225-17/+62
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8595: Diagnostic paths support specifying `remapPrefix` r=rickvanprim a=rickvanprim Currently VSCode Problem Matchers will resolve a path like `//foo_crate/src/main.rs` if `${workspaceFolder}/foo_crate/src/main.rs` exists. Presumably their behavior is functionally a string concatenation that would produce `${workspaceFolder///foo_crate/src/main.rs` and repeated path separators get ignored. This PR attempts to mimic this behavior by stripping any `Component::RootDir` from `file_name` before joining it to `workspace_root`, and then checking if the file exists. If it does, this path is used, and if not, the behavior falls through to the existing Rust path join behavior. Co-authored-by: James Leitch <[email protected]>
| * | | | | | | Code review feedback.James Leitch2021-04-215-12/+14
| | | | | | | |
| * | | | | | | Diagnostic Remap Path Prefixes added.James Leitch2021-04-215-37/+53
| | | | | | | |
| * | | | | | | Diagnostic paths attempt to use VSCode's path join behavior before ↵James Leitch2021-04-211-3/+30
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | defaulting to Rust's path join behavior.
* | | | | | | Merge #8570bors[bot]2021-04-213-22/+48
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8570: Flycheck tries to parse both Cargo and Rustc messages. r=rickvanprim a=rickvanprim This change allows non-Cargo build systems to be used for Flycheck provided they call `rustc` with `--error-format=json` and emit those JSON messages to `stdout`. Co-authored-by: James Leitch <[email protected]>
| * | | | | | | Code review feedback.James Leitch2021-04-191-15/+16
| | | | | | | |
| * | | | | | | Flycheck tries to parse both Cargo and Rustc messages.James Leitch2021-04-193-22/+47
| | | | | | | |