aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5819bors[bot]2020-08-191-19/+16
|\ | | | | | | | | | | | | | | | | | | 5819: Apply couple of rule of thumbs to simplify highlighting code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Apply couple of rule of thumbs to simplify highlighting codeAleksey Kladov2020-08-191-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Main one: instead of adding a parameter to function to handle special case, make the caller handle it. Second main one: make sure that function does a reasonable thing. `highlight_def` picks a color for def, *regardless* of the context the def is use. Feeding an info from the call-site muddies the responsibilities here. Minor smells, flagging the function as having space for improvement in the first place: * many parameters, some of which are set as constants on most call-sites (introduce severalfunction instad) * boolean param (add two functions instead)
* | Merge #5818bors[bot]2020-08-191-19/+11
|\| | | | | | | | | | | | | | | | | 5818: Some trivial local simiplifications r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Inline trivial functionAleksey Kladov2020-08-191-8/+6
| |
| * SimplifyAleksey Kladov2020-08-191-9/+4
| |
| * MinorAleksey Kladov2020-08-191-2/+1
| |
| * Minor cleanupsAleksey Kladov2020-08-191-1/+1
| |
| * Better nameAleksey Kladov2020-08-191-4/+4
|/
* Merge #5817bors[bot]2020-08-194-56/+30
|\ | | | | | | | | | | | | | | | | | | 5817: Better API factoring around self access modes r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Better API factoring around self access modesAleksey Kladov2020-08-194-56/+30
| |
* | Merge #5816bors[bot]2020-08-191-2/+9
|\| | | | | | | | | | | | | | | | | | | 5816: Better error if Cargo is not in Path r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Better error if Cargo is not in PathAleksey Kladov2020-08-191-2/+9
| |
* | Merge #5815bors[bot]2020-08-191-2/+11
|\| | | | | | | | | | | | | | | | | | | 5815: Introduce hir::Param r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Introduce hir::ParamAleksey Kladov2020-08-191-2/+11
|/ | | | | We generally shouldn't expose TypeRef out of hir. So, let's just use a placehoder here.
* Merge #5814bors[bot]2020-08-199-43/+62
|\ | | | | | | | | | | | | | | | | | | 5814: Add SelfParam to code_model r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add SelfParam to code_modelAleksey Kladov2020-08-199-43/+62
| |
* | Merge #5812bors[bot]2020-08-191-7/+6
|\| | | | | | | | | | | | | | | | | | | 5812: Minor cleanups r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Minor cleanupsAleksey Kladov2020-08-191-7/+6
|/
* Merge #5811bors[bot]2020-08-191-3/+3
|\ | | | | | | | | | | | | | | | | | | 5811: Minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * MinorAleksey Kladov2020-08-191-3/+3
| |
* | Merge #5643bors[bot]2020-08-199-49/+220
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | 5643: Add new consuming modifier, apply consuming and mutable to methods r=matklad a=Nashenas88 This adds a new `consuming` semantic modifier for syntax highlighters. This also emits `mutable` and `consuming` in two cases: - When a method takes `&mut self`, then it now has `function.mutable` emitted. - When a method takes `self`, and the type of `Self` is not `Copy`, then `function.consuming` is emitted. CC @flodiebold Co-authored-by: Paul Daniel Faria <[email protected]>
| * Add new method to Semantics, method_receiver_kind, which returns the kind of ↵Paul Daniel Faria2020-08-165-70/+181
| | | | | | | | | | | | | | self The options are Shared, Mutable, Consuming, and Copied. Use this to add proper highlighting to methods based on usage.
| * Mark mutating functions with `mutable` modifier, and owning functions with ↵Paul Daniel Faria2020-08-165-15/+70
| | | | | | | | `consuming`.
| * Add new HighlightModifier variant, ConsumingPaul Daniel Faria2020-08-163-0/+5
| |
* | Merge #5809bors[bot]2020-08-181-6/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5809: :arrow_up: crates r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | :arrow_up: cratesAleksey Kladov2020-08-181-6/+6
| | |
* | | Merge #5808bors[bot]2020-08-181-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5808: Make RacyFlag actually work r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Make RacyFlag actually workAleksey Kladov2020-08-181-1/+1
|/ /
* | Merge #5807bors[bot]2020-08-1812-115/+95
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5807: Cleanup feature generation r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Cleanup feature generationAleksey Kladov2020-08-1812-115/+95
| | |
* | | Merge #5806bors[bot]2020-08-181-11/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5806: Add GH Sposors to FUNDING.yml r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Add GH Sposors to FUNDING.ymlAleksey Kladov2020-08-181-11/+1
| | | |
* | | | Merge #5805bors[bot]2020-08-181-1/+2
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5805: Encourage rebases more r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Encourage rebases moreAleksey Kladov2020-08-181-1/+2
| |/ /
* | | Merge #5695bors[bot]2020-08-188-8/+100
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 5695: Added completion for unstable features r=matklad a=Fihtangolz Added xtask for downloading list of unstable features from the unstable book and codegen for it. Also included small changes from linter. Co-authored-by: Dmitry <[email protected]> Co-authored-by: Dmitry Opokin <[email protected]>
| * | fmtDmitry2020-08-181-1/+1
| | |
| * | fix reformatDmitry2020-08-181-2/+2
| | |
| * | Merge remote-tracking branch 'rust-analyzer/master'Dmitry2020-08-1865-327/+859
| |\ \
| * | | synchronizing changesDmitry2020-08-146-14/+28
| | | |
| * | | Merge remote-tracking branch 'origin/master'Dmitry2020-08-141454-97664/+98243
| |\ \ \
| * | | | refactor requirements put forward mkladovDmitry2020-08-143-21/+22
| | | | |
| * | | | restrict visibility only by crateDmitry2020-08-142-2/+2
| | | | |
| * | | | Merge branch 'master' of https://github.com/Fihtangolz/rust-analyzer into masterDmitry2020-08-141-1/+1
| |\ \ \ \
| | * | | | Update xtask/src/codegen/gen_unstable_future_descriptor.rsDmitry Opokin2020-08-141-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Revert "replase sparse-checkout by github api"Dmitry2020-08-147-39274/+23
| |/ / / / | | | | | | | | | | | | | | | This reverts commit 034db28c542c04b22147da6722328bc74ff99386.
| * | | | replase sparse-checkout by github apiDmitry2020-08-147-23/+39274
| | | | |
| * | | | remove fmt skip attrDmitry2020-08-102-3/+1
| |\ \ \ \
| | * | | | refactoring to show more clearly the import problemsDmitry2020-08-092-6/+6
| | | | | |
| * | | | | refactoring to show more clearly the import problemsDmitry2020-08-092-6/+6
| |/ / / /
| * | | | fix tidy checkDmitry2020-08-091-0/+2
| | | | |