aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #3424bors[bot]2020-03-034-57/+85
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 3424: Highlight assist tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Highlight assist testsAleksey Kladov2020-03-033-49/+53
| | |
| * | Fix applicability of inline localAleksey Kladov2020-03-033-10/+34
| | |
* | | Merge #3423bors[bot]2020-03-031-2/+2
|\| | | |/ |/| | | | | | | | | | | | | | | | | 3423: Remove stray dbg r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove stray dbgAleksey Kladov2020-03-031-2/+2
|/
* Merge #3388bors[bot]2020-03-035-15/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3388: Remove inlay hint in diff views r=matklad a=vbfox If the left side of a diff view that contain the old version of the file apply inlays they are misplaced and produce a weird display: ![image](https://user-images.githubusercontent.com/131878/75628802-b1ac1900-5bdc-11ea-8c26-6722d8e38371.png) After the change: ![image](https://user-images.githubusercontent.com/131878/75628831-e91ac580-5bdc-11ea-9039-c6b4ffbdb2be.png) The detection is done by blacklisting the url schemes used by git and subversion scm extensions, whitelisting `file` is also possible but neither is perfect as VSCode now support both pluggable scm extensions and pluggable remote filesystems. But I suspect that the list of scm extensions is more easily manageable. **Note**: I can rebase on #3378 if needed as it touches the same lines of code Co-authored-by: Julien Roncaglia <[email protected]>
| * Centralize the check for languageId on documentJulien Roncaglia2020-03-025-24/+25
| | | | | | | | Also move visibleRustEditors to Ctx
| * Remove inlay in diff viewsJulien Roncaglia2020-03-011-1/+10
| | | | | | | | | | | | | | | | If the left side of a diff view that contain the old version of the file apply inlays they are misplaced. The detection is done by blacklisting the url schemes used by git and subversion scm extensions.
* | Merge #3420bors[bot]2020-03-032-70/+105
|\ \ | | | | | | | | | | | | | | | | | | | | | 3420: Update code dependencies r=matklad a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Update code dependenciesJeremy Kolb2020-03-032-70/+105
|/ /
* | Merge #3417bors[bot]2020-03-033-11/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 3417: Drop larlpop-intern dependency r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Drop larlpop-intern depLaurențiu Nicola2020-03-033-11/+2
| | |
* | | Merge #3416bors[bot]2020-03-032-3/+6
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3416: Clean xtask partial artifacts in `xtask pre-cache` r=matklad a=CAD97 Confirmed that these aren't getting deleted locally. This won't actually change what's cached until the cache key changes. Co-authored-by: Christopher Durham <[email protected]>
| * | Clean xtask partial artifacts in `xtask pre-cache`Christopher Durham2020-03-032-3/+6
|/ /
* | Merge #3413bors[bot]2020-03-023-31/+27
|\ \ | | | | | | | | | | | | | | | | | | | | | 3413: Update chalk for RawId removal, Ty interners r=flodiebold a=lnicola r? @flodiebold Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Update chalk for Ty internersLaurențiu Nicola2020-03-023-17/+20
| | |
| * | Update chalk for RawId removalLaurențiu Nicola2020-03-023-23/+16
|/ /
* | Merge #3410bors[bot]2020-03-021-4/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | 3410: Update deps r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update depskjeremy2020-03-021-4/+4
| | |
* | | Merge #3408bors[bot]2020-03-021-2/+2
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3408: Simplify by using to_vec r=kiljacken a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Simplify by using to_veckjeremy2020-03-021-2/+2
|/ /
* | Merge #3406bors[bot]2020-03-022-23/+13
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3406: Simplify: remove couple of useless functions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Simplify: remove couple of useless functionsAleksey Kladov2020-03-022-23/+13
| | |
* | | Merge #3405bors[bot]2020-03-027-36/+79
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3405: More principled approach for gotodef for field shorhand r=matklad a=matklad Callers can now decide for themselves if they should prefer field or local definition. By default, it's the local. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | More principled approach for gotodef for field shorhandAleksey Kladov2020-03-027-36/+79
| | | | | | | | | | | | | | | Callers can now decide for themselves if they should prefer field or local definition. By default, it's the local.
* | | Merge #3404bors[bot]2020-03-025-16/+13
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3404: lsp-types 0.72 r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | lsp-types 0.72kjeremy2020-03-025-16/+13
|/ /
* | Merge #3401bors[bot]2020-03-021-0/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3401: Print log on release r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Print log on releaseAleksey Kladov2020-03-021-0/+9
| | |
* | | Merge #3400bors[bot]2020-03-021-4/+6
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3400: Don't fail loudly if the old highlighting breaks r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Don't fail loudly if the old highlighting breaksAleksey Kladov2020-03-021-4/+6
|/ /
| |
| \
*-. \ Merge #3397 #3398bors[bot]2020-03-024-12/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3397: Minimal viable meta r=matklad a=matklad bors r+ 🤖 3398: Reformat? r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Reformat?Aleksey Kladov2020-03-022-11/+3
| | | |
| * | | Minimal viable metaAleksey Kladov2020-03-022-1/+11
| |/ /
* | | Merge #3385bors[bot]2020-03-024-6/+45
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 3385: Fix #3373 r=matklad a=flodiebold Basically, we need to allow variables in the caller self type to unify with the impl's declared self type. That requires some more contortions in the variable handling. I'm looking forward to (hopefully) handling this in a cleaner way when we switch to Chalk's types and unification code. Co-authored-by: Florian Diebold <[email protected]>
| * | Fix #3373Florian Diebold2020-03-014-6/+45
| |/ | | | | | | | | | | | | Basically, we need to allow variables in the caller self type to unify with the impl's declared self type. That requires some more contortions in the variable handling. I'm looking forward to (hopefully) handling this in a cleaner way when we switch to Chalk's types and unification code.
* | Merge #3396bors[bot]2020-03-021-1/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3396: One more assert r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | One more assertAleksey Kladov2020-03-021-1/+6
| | |
* | | Merge #3395bors[bot]2020-03-021-0/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3395: Tighten up an assert r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Tighten up an assertAleksey Kladov2020-03-021-0/+4
|/ /
* | Merge #3389bors[bot]2020-03-021-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3389: Note vscode remote limitation when client install fails r=matklad a=not-much-io Just adding a note about the limitation referenced in https://github.com/rust-analyzer/rust-analyzer/issues/2522/ Considered checking if this message is relevant in the context (is this remote?) but decided against it because of return on investment - seeing how fast vscode iterates this limitation might just disappear in the near future. Also checked if there is a way to already do this which lead me to leaving a specifing question at https://github.com/microsoft/vscode-remote-release/issues/385 Co-authored-by: nmio <[email protected]>
| * | Readabilitynmio2020-03-011-1/+3
| | |
| * | Add notenmio2020-03-011-2/+1
| |/
* | Merge #3387bors[bot]2020-03-012-2/+108
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3387: Type inference for slice patterns r=flodiebold a=JoshMcguigan Fixes #3043 Notes to reviewer: 1. This only works if `expected` is `Ty::Apply`. I'm not sure of the implications of this. 1. This only works if the slice pattern only has a prefix. I think this means it doesn't work for subslice patterns, which are currently only available behind a feature flag. Co-authored-by: Josh Mcguigan <[email protected]>
| * | handle array pattern matching type inferenceJosh Mcguigan2020-03-012-10/+55
| | |
| * | remove match statement, handle suffixJosh Mcguigan2020-03-012-14/+11
| | |
| * | handle arbitrary length slicesJosh Mcguigan2020-03-012-12/+29
| | |
| * | match single prefix sliceJosh Mcguigan2020-03-012-1/+48
| |/
* | Merge #3384bors[bot]2020-03-014-6/+88
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 3384: fix #2377 super::super::* r=flodiebold a=JoshMcguigan Thanks @matklad for the detailed explanation on #2377. I believe this fixes it. One thing I'm not sure about is you said the fix would involve changing `crates/ra_hir_def/src/path/lower/lower.rs`, but I only changed `crates/ra_hir_def/src/path/lower/lower_use.rs`. I'm not sure what kind of test code I'd have to write to expose the issue in `lower.rs`, but I'd be happy to add it if you are able to provide additional guidance. closes #2377 Co-authored-by: Josh Mcguigan <[email protected]>
| * fix completion for super::super::Josh Mcguigan2020-03-012-2/+45
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 05:28:05 +0100