aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | Remove `ItemTree::all_inner_items`Jonas Schievink2021-04-211-7/+0
|/ / / / / / / / /
* | | | | | | | | Merge #8613bors[bot]2021-04-213-0/+46
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8613: skip: Add failing local items test r=jonas-schievink a=jonas-schievink This is currently broken due to the way ItemTree stores inner items. This test serves as a reminder until this gets fixed. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | | | Add failing local items testJonas Schievink2021-04-213-0/+46
|/ / / / / / / / /
* | | | | | | | | Merge #8611bors[bot]2021-04-212-23/+207
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8611: Add support for fill match arms of boolean values r=flodiebold a=komonad - Add support for boolean inside tuple closes #8593 Co-authored-by: Comonad <[email protected]>
| * | | | | | | | Add support for fill match arms of boolean valuesComonad2021-04-212-23/+207
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | - Add support for boolean inside tuple
* | | | | | | | Merge #8609bors[bot]2021-04-213-8/+57
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8609: Parse outer atttributes for RecordPatField r=Veykril a=Veykril Fixes #8608 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | | | Parse outer atttributes for RecordPatFieldLukas Wirth2021-04-213-8/+57
|/ / / / / / / /
* | | | | | | | Merge #8606bors[bot]2021-04-202-2/+13
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8606: fix: no more Registering progress handler for token rustAnalyzer/Ind… r=jonas-schievink a=matklad …exing failed. closes #8509 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | fix: no more Registering progress handler for token rustAnalyzer/Indexing ↵Aleksey Kladov2021-04-202-2/+13
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | failed.
* | | | | | | Merge #8600bors[bot]2021-04-205-65/+330
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8600: fix: no longer get stuck on windows r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | fix: no longer get stuck on windowsAleksey Kladov2021-04-205-65/+330
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reading both stdout & stderr is a common gotcha, you need to drain them concurrently to avoid deadlocks. Not sure why I didn't do the right thing from the start. Seems like I assumed the stderr is short? That's not the case when cargo spams `compiling xyz` messages
* | | | | | | | Merge #8602bors[bot]2021-04-201-28/+45
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8602: Fix panic in `replace_derive_with_manual_impl` r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | | Follow testing style guideJonas Schievink2021-04-201-28/+28
| | | | | | | | |
| * | | | | | | | Fix panic in `replace_derive_with_manual_impl`Jonas Schievink2021-04-201-0/+17
| |/ / / / / / /
* | | | | | | | Merge #8601bors[bot]2021-04-201-38/+185
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8601: Trigger "Inline variable" assist when on a use of the variable r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8530 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | "Inline variable" when on a use of the variableJonas Schievink2021-04-201-38/+185
| | |/ / / / / | |/| | | | |
* | | | | | | Merge #8598bors[bot]2021-04-201-26/+48
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8598: minor: fix ugly line wrapping in the rendered manual r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | minor: fix ugly line wrapping in the rendered manualAleksey Kladov2021-04-201-26/+48
| | | | | | |
| | | | * | | Don't filter equal nodes in reorder assistsLukas Wirth2021-04-212-10/+6
| | | | | | |
| | | | * | | Add cov_marks to insert_use testsLukas Wirth2021-04-207-42/+77
| | | | | | |
| | | | * | | Rewrite extract_struct_from_enum_variant assistLukas Wirth2021-04-201-85/+91
| | | | | | |
| | | | * | | Remove SyntaxRewriter usage in insert_use in favor of tedLukas Wirth2021-04-208-243/+185
| | | | | | |
| | | | * | | Replace SyntaxRewriter usage with ted in reorder_impl assistLukas Wirth2021-04-201-9/+13
| |_|_|/ / / |/| | | | |
* | | | | | Merge #8588bors[bot]2021-04-191-0/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | | internal: Add guidelines for release notes PR descriptionsLaurențiu Nicola2021-04-191-0/+11
| | | | | | |
* | | | | | | Merge #8586bors[bot]2021-04-192-23/+18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8586: Replace SyntaxRewriter usage with ted in eager::eager_macro_recur r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | | Replace SyntaxRewriter with ted in exppand_macro::expand_macro_recurLukas Wirth2021-04-191-14/+9
| | | | | | | |
| * | | | | | | Remove SyntaxRewriter usage in eager::eager_macro_recurLukas Wirth2021-04-191-9/+9
| | | | | | | |
* | | | | | | | Merge #8587bors[bot]2021-04-192-5/+91
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8587: Fix some find_path bugs around inner items r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8519 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | Add autoimport test with inner itemsJonas Schievink2021-04-191-0/+33
| | | | | | | |
| * | | | | | | Fix some find_path bugs around inner itemsJonas Schievink2021-04-191-5/+58
|/ / / / / / /
* | | | | | | Merge #8584bors[bot]2021-04-191-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8584: internal: fix slightly broken test r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | internal: fix slightly broken testAleksey Kladov2021-04-191-1/+1
| | | | | | | |
* | | | | | | | Merge #8583bors[bot]2021-04-191-23/+14
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8583: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | | SimplifyLukas Wirth2021-04-191-23/+14
| |/ / / / / /
* | | | | | | Merge #8582bors[bot]2021-04-194-5/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8582: Fix typo: comparision -> comparison r=kjeremy a=stanciuadrian Closes #8576 Co-authored-by: Adrian Stanciu <[email protected]>
| * | | | | | | Fix typo: comparision -> comparisonAdrian Stanciu2021-04-194-5/+5
| |/ / / / / /
* | | | | | | Merge #8580bors[bot]2021-04-191-3/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8580: Remove confusion around serverStatusNotification r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Remove confusion around serverStatusNotificationAleksey Kladov2021-04-191-3/+8
|/ / / / / / /
* | | | | | | Merge #8579bors[bot]2021-04-191-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8579: Fix spec bug r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Fix spec bugAleksey Kladov2021-04-191-1/+1
|/ / / / / / /
* | | | | | | Merge #8578bors[bot]2021-04-196-182/+238
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8578: fix: false positive about inner attrs in docs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | fix: false positive about inner attrs in docsAleksey Kladov2021-04-196-182/+238
| | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #8541
* | | | | | | Merge #8577bors[bot]2021-04-191-17/+41
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8577: Support crates/module roots in external_docs r=Veykril a=Veykril Fixes #8575 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | | | Support crates/module roots in external_docsLukas Wirth2021-04-191-17/+41
| | |/ / / / / | |/| | | | |
* | | | | | | Merge #8502bors[bot]2021-04-191-0/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8502: internal: document review requesting etiquette r=matklad a=matklad * don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Update docs/dev/README.mdAleksey Kladov2021-04-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | | | | internal: document review requesting etiquetteAleksey Kladov2021-04-191-0/+3
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you
| | | | | | |
| \ \ \ \ \ \
*-. \ \ \ \ \ \ Merge #8524 #8527bors[bot]2021-04-194-38/+298
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8524: Fix extract function with partial block selection r=matklad a=brandondong **Reproduction:** ```rust fn foo() { let n = 1; let mut v = $0n * n;$0 v += 1; } ``` 1. Select the snippet ($0) and use the "Extract into function" assist. 2. Extracted function is incorrect and does not compile: ```rust fn foo() { let n = 1; let mut v = fun_name(n); v += 1; } fn fun_name(n: i32) {} ``` 3. Omitting the ending semicolon from the selection fixes the extracted function: ```rust fn fun_name(n: i32) -> i32 { n * n } ``` **Cause:** - When `extraction_target` uses a block extraction (semicolon case) instead of an expression extraction (no semicolon case), the user selection is directly used as the TextRange. - However, the existing function extraction logic for blocks requires that the TextRange spans from start to end of complete statements to work correctly. - For example: ```rust fn foo() { let m = 2; let n = 1; let mut v = m $0* n; let mut w = 3;$0 v += 1; w += 1; } ``` produces ```rust fn foo() { let m = 2; let n = 1; let mut v = m let mut w = fun_name(n); v += 1; w += 1; } fn fun_name(n: i32) -> i32 { let mut w = 3; w } ``` - The user selected TextRange is directly replaced by the function call which is now in the middle of another statement. The extracted function body only contains statements that were fully covered by the TextRange and so the `* n` code is deleted. The logic for calculating variable usage and outlived variables for the function parameters and return type respectively search within the TextRange and so do not include `m` or `v`. **Fix:** - Only extract full statements when using block extraction. If a user selected part of a statement, extract that full statement. 8527: Switch introduce_named_lifetime assist to use mutable syntax tree r=matklad a=iDawer This extends `GenericParamsOwnerEdit` trait with `get_or_create_generic_param_list` method Co-authored-by: Brandon <[email protected]> Co-authored-by: Dawer <[email protected]>
| | * | | | | | Finish GenericParamsOwnerEdit implsDawer2021-04-151-5/+94
| | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 19:10:01 +0000