aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4445bors[bot]2020-05-145-2/+92
|\ | | | | | | | | | | | | | | | | | | 4445: Correctly fill default type parameters r=flodiebold a=montekki Fixes #3877 So, basically even if the parameters are omitted from the `impl` block, check the parameters in `trait` if they have a default type, and if they do go from `hir` to `ast::TypeArg`. I've added a helper for that but I am not sure that it's a proper way to go from `hir` to `ast` here. Co-authored-by: Fedor Sakharov <[email protected]>
| * Ty -> TypeFedor Sakharov2020-05-141-2/+7
| |
| * Adds a param_idx helperFedor Sakharov2020-05-142-2/+7
| |
| * Fix formattingFedor Sakharov2020-05-141-1/+1
| |
| * Change type_arg to type_ref funcFedor Sakharov2020-05-142-4/+3
| |
| * Use generic_defaults and display_source_codeFedor Sakharov2020-05-144-14/+16
| |
| * Correctly fill default type parametersFedor Sakharov2020-05-136-1/+80
| |
* | Merge #4405bors[bot]2020-05-146-10/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4405: Make some stuff public so that they can be reused by other tools r=pksunkara a=pksunkara So, my little experiment of building a code analysis tool using rust-analyzer is successful. I am going to proceed to build the tool now. This PR makes the needed things public. I know there were some things about trying to change stuff regarding loading workspaces, which would make it more easier for other tools to reuse. But, until then, it should be okay using this `load_cargo` fn. Btw, if I were publish my tool, I would need the `ra` crates to be released. Since @matklad told me that he doesn't want to care about breaking stuff, I would propose the following. Every monday, during the weekly release, we release a new pre v1 minor version of all the crates. That way, we don't need to care about breaking stuff but still have rust-analyzer on crates.io. I made https://github.com/pksunkara/cargo-workspaces to help release workspace crates easily. So, coming week, we start with `0.1.0`, then week after that, we release `0.2.0` and then `0.3.0` etc.. until we decide on `1.0.0` which is probably when the compiler team also starts using the crates. There is no limit to the minor versions (we can even have `0.150.0` or `0.1500.0`), so I don't see anything wrong with this strategy. Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * | Make some stuff public so that they can be reused by other toolsPavan Kumar Sunkara2020-05-146-10/+7
| | |
* | | Merge #4432bors[bot]2020-05-141-2/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4432: Update features.md r=matklad a=bnjjj Co-authored-by: Coenen Benjamin <[email protected]>
| * | | Update features.mdCoenen Benjamin2020-05-121-2/+12
| | | |
* | | | Merge #4452bors[bot]2020-05-144-4/+4
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 4452: Use back ticks instead of single quotes around code r=matklad a=tspiteri Also, use back ticks instead of single quotes in `rustc_unescape_error_to_string` for `EE:UnclosedUnicodeEscape`. Co-authored-by: Trevor Spiteri <[email protected]>
| * | | Use back ticks instead of single quotes around codeTrevor Spiteri2020-05-144-4/+4
|/ / /
* | | Merge #4447bors[bot]2020-05-131-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4447: Remove VARIATION SELECTOR-16 in Run arrow r=matklad a=lnicola Closes #4446, cc @Veetaha. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Remove hidden VARIATION SELECTOR-16Laurențiu Nicola2020-05-131-2/+2
| | | |
* | | | Merge #4400bors[bot]2020-05-131-0/+3
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4400: Enhanced coloring r=georgewfraser a=georgewfraser This PR builds on #4397 to enhance the existing syntax coloring. ## Underline mutable variables The textmate scope `markup.underline` underlines identifiers, which is a nice way to make mutable vars stand out: <img width="327" alt="Screen Shot 2020-05-09 at 1 18 55 PM" src="https://user-images.githubusercontent.com/1369240/81484179-8bb47d80-91f8-11ea-997d-1dcffbe44aa7.png"> ## Italicize static variables The textmate scope `markup.italic` italicizes identifiers. Italic = static is a common convention in IDEs like IntelliJ: <img width="288" alt="Screen Shot 2020-05-09 at 1 19 14 PM" src="https://user-images.githubusercontent.com/1369240/81484236-cd452880-91f8-11ea-8478-505ee49bc8b3.png"> Co-authored-by: George Fraser <[email protected]>
| * | | Leave statics aloneGeorge Fraser2020-05-121-3/+0
| | | |
| * | | Mark up statics and mutablesGeorge Fraser2020-05-121-0/+6
| | | |
* | | | Merge #4444bors[bot]2020-05-131-6/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4444: Update crates r=kjeremy a=kjeremy Documentation improvements Co-authored-by: kjeremy <[email protected]>
| * | | | Update crateskjeremy2020-05-131-6/+6
| | |/ / | |/| | | | | | | | | | Documentation improvements
* | | | Merge #4440bors[bot]2020-05-132-51/+59
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 4440: Update packages r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | Bump packageskjeremy2020-05-132-50/+58
| | | |
| * | | vscode engine 1.45kjeremy2020-05-121-1/+1
| | | | | | | | | | | | | | | | latest stable
* | | | Merge #4434bors[bot]2020-05-131-15/+43
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4434: add more specific match postfix for Result and Option r=matklad a=bnjjj In order to have the same behavior than `if let` and `while let` Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | add more specific match postfix for Result and OptionBenjamin Coenen2020-05-121-15/+43
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #4083bors[bot]2020-05-134-153/+2877
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4083: Smol documentation for ast nodes r=matklad a=Veetaha There is a tremendous amount of TODOs to clarify the topics I am not certain about. Please @matklad, @edwin0cheng review carefully, I even left some mentions of your names in todos to put your attention where you most probably can give comments. In order to simplify the review, I separated the codegen (i.e. changes in `ast/generated/nodes.rs`) from `ast_src` changes (they in fact just duplicate one another) into two commits. Also, I had to hack a little bit to let the docs be generated as doc comments and not as doc attributes because it's easier to read them this way and IIRC we don't support hints for `#[doc = ""]` attributes for now... Closes #3682 Co-authored-by: veetaha <[email protected]>
| * | | | Convert TODO about ParamList used in closures to a FIXMEveetaha2020-05-121-2/+1
| | | | | | | | | | | | | | | | | | | | cc @matklad (you didn't comment on this one)
| * | | | Remove an equals sign from `ConstArg` (this probably pertains only to ↵veetaha2020-05-122-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ConstParam) (As per matklad)
| * | | | Remove a comment on NameRefToken as per matkladveetaha2020-05-121-1/+1
| | | | |
| * | | | Convert TODO to a FIXME as per matkladveetaha2020-05-121-1/+1
| | | | |
| * | | | Convert TODO to a Note(matklad)veetaha2020-05-122-1/+2
| | | | |
| * | | | Convert to TODOs to FIXMEs as per matkladveetaha2020-05-122-8/+4
| | | | |
| * | | | Revert "Remove MacroStmts as per edwin0cheng" (cc @edwin0cheng) and add a ↵veetaha2020-05-122-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixme to document it. This reverts commit 7a49165f5d5c8186edd04f874eae8a98e39d3df6. MacroStmts ast node is not used by itself, but it pertains to SyntaxNodeKind MACRO_STMTS that is used by ra_paser, so even tho the node itself is not used, it is better to keep it with a FIXME to actually add a doc comment when it becomes useful.
| * | | | Add a doc comment on the difference between Name and NameRef ast nodesveetaha2020-05-122-2/+32
| | | | |
| * | | | Resolve TODO about macro 2.0 defveetaha2020-05-102-14/+8
| | | | |
| * | | | Fix typoveetaha2020-05-102-2/+2
| | | | |
| * | | | Carify on a semicolon in macro callveetaha2020-05-102-3/+13
| | | | |
| * | | | Resolve TODO about curly-braced constructions in expression statementveetaha2020-05-102-2/+6
| | | | |
| * | | | Remove TODO about Block since it was removedveetaha2020-05-101-3/+3
| | | | |
| * | | | Resolve todos about refs and empty statementsveetaha2020-05-102-9/+8
| | | | |
| * | | | Converted TODO about MacroItems to FIXME as per edwin0chengveetaha2020-05-102-14/+5
| | | | |
| * | | | Verified ConstArg example, waiting for response on what `=` sign pertains toveetaha2020-05-102-5/+4
| | | | |
| * | | | Correcy use tree and type args docsveetaha2020-05-102-8/+6
| | | | |
| * | | | Fix "show syntax tree" commandveetaha2020-05-101-1/+1
| | | | | | | | | | | | | | | | | | | | @matlkad please don't forget to keep it up-to-date!
| * | | | Correct `use` cannot have type args as per flodieboldveetaha2020-05-102-2/+2
| | | | |
| * | | | Correct path docs and add colon2 token to Path ast nodeveetaha2020-05-102-20/+28
| | | | |
| * | | | Add example with const in TypeBound as per flodieboldveetaha2020-05-102-5/+3
| | | | |
| * | | | Remove todo comment about arg vs param difference as per clarification from ↵veetaha2020-05-101-4/+0
| | | | | | | | | | | | | | | | | | | | flodiebold
| * | | | Properly document const impl as per flodieboldveetaha2020-05-102-4/+4
| | | | |
| * | | | Remove on TypeAliasDef as per flodieboldveetaha2020-05-101-2/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 05:41:33 +0000