Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #6553 | bors[bot] | 2020-11-17 | 1 | -2/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6553: Auto imports in completion r=matklad a=SomeoneToIgnore ![completion](https://user-images.githubusercontent.com/2690773/99155339-ae4fb380-26bf-11eb-805a-655b1706ce70.gif) Closes https://github.com/rust-analyzer/rust-analyzer/issues/1062 but does not handle the completion order, since it's a separate task for https://github.com/rust-analyzer/rust-analyzer/issues/4922 , https://github.com/rust-analyzer/rust-analyzer/issues/4922 and maybe something else. 2 quirks in the current implementation: * traits are not auto imported during method completion If I understand the current situation right, we cannot search for traits by a **part** of a method name, we need a full name with correct case to get a trait for it. * VSCode (?) autocompletion is not as rigid as in Intellij Rust as you can notice on the animation. Intellij is able to refresh the completions on every new symbol added, yet VS Code does not query the completions on every symbol for me. With a few debug prints placed in RA, I've observed the following behaviour: after the first set of completion suggestions is received, next symbol input does not trigger a server request, if the completions contain this symbol. When more symbols added, the existing completion suggestions are filtered out until none are left and only then, on the next symbol it queries for completions. It seems like the only alternative to get an updated set of results is to manually retrigger it with Esc and Ctrl + Space. Despite the eerie latter bullet, the completion seems to work pretty fine and fast nontheless, but if you have any ideas on how to make it more smooth, I'll gladly try it out. Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | Add imports in auto completion | Kirill Bulatov | 2020-11-16 | 1 | -2/+1 |
| | | |||||
* | | Add **Ignore Test** assist | Aleksey Kladov | 2020-11-17 | 1 | -0/+18 |
|/ | |||||
* | add suggestion ..Default::default() for remaining struct fields in a ↵ | Benjamin Coenen | 2020-11-13 | 1 | -1/+1 |
| | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]> | ||||
* | add suggestion ..Default::default() for remaining struct fields in a ↵ | Benjamin Coenen | 2020-11-13 | 1 | -1/+11 |
| | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]> | ||||
* | Add missing AssocItems in add_custom_impl assist | Lukas Wirth | 2020-11-05 | 1 | -3/+89 |
| | |||||
* | Remove dependency on 'assists' from 'completion' crate | Igor Aleksanov | 2020-10-24 | 1 | -118/+3 |
| | |||||
* | Don't rely on display names in inlay_hints | Aleksey Kladov | 2020-10-20 | 1 | -11/+14 |
| | |||||
* | Rename declaration_name -> display_name | Aleksey Kladov | 2020-10-20 | 1 | -1/+1 |
| | | | | | | | | Declaration names sounds like a name of declaration -- something you can use for analysis. It empathically isn't, and is just a label displayed in various UI. It's important not to confuse the two, least we accidentally mix semantics with UI (I believe, there's already a case of this in the FamousDefs at least). | ||||
* | Extract ImportAssets out of auto_import | Lukas Wirth | 2020-10-13 | 1 | -0/+1 |
| | |||||
* | Clean up inlay_hints | Lukas Wirth | 2020-10-07 | 1 | -1/+12 |
| | |||||
* | Shorten iterator hints for std::iter iterators behind references | Lukas Wirth | 2020-10-07 | 1 | -1/+1 |
| | |||||
* | Shorten iterator chain hints | Lukas Wirth | 2020-10-07 | 1 | -7/+34 |
| | |||||
* | Move IntoIterator into FamousDefs | Lukas Wirth | 2020-10-07 | 1 | -8/+15 |
| | |||||
* | Use FamousDefs for shorten_iterator hint | Lukas Wirth | 2020-10-06 | 1 | -12/+49 |
| | |||||
* | Move ModPath->ast::Path function to IDE layer | Aleksey Kladov | 2020-10-06 | 1 | -0/+21 |
| | | | | closes #6092 | ||||
* | Make MergeBehaviour configurable | Lukas Wirth | 2020-09-12 | 1 | -1/+2 |
| | |||||
* | Fix import insertion breaking nested modules | Lukas Wirth | 2020-09-03 | 1 | -1/+1 |
| | |||||
* | Impl make::blank_line | Lukas Wirth | 2020-09-03 | 1 | -1/+1 |
| | |||||
* | Cleanup invert-if | Aleksey Kladov | 2020-08-25 | 1 | -19/+14 |
| | | | | | * stick to trivial factory functions in make * compress the logic for inverting Option/Result | ||||
* | Invert if should be smart about is_some, is_none, is_ok, is_err | dragfire | 2020-08-24 | 1 | -1/+20 |
| | |||||
* | **Remove Unused Parameter** refactoring | Aleksey Kladov | 2020-08-19 | 1 | -1/+5 |
| | |||||
* | Rename ra_assists -> assists | Aleksey Kladov | 2020-08-13 | 1 | -0/+313 |