aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src/references/rename.rs
Commit message (Collapse)AuthorAgeFilesLines
* internal: flatten module hierarchyAleksey Kladov2021-06-141-1788/+0
| | | | | It seems that any crate can be made better by flattening the modules down to a single layer?
* internal: document rename challengesAleksey Kladov2021-06-141-0/+18
|
* internal: adapt diagnostics to the new rename APIAleksey Kladov2021-06-141-423/+12
|
* internal: prepare to move rename to base_dbAleksey Kladov2021-06-141-41/+40
| | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there.
* fix: don't use display-related functionality where semantics mattersAleksey Kladov2021-06-141-41/+119
| | | | | | | NavigationTarget is strictly a UI-level thing -- it describes where the cursor should be placed when the user presses goto definition. It doesn't make any semantic guaratees about rage and focus range and, as such, is not suitable for driving renames.
* clippy::redundant_closureMaan20032021-06-131-1/+1
|
* clippy::redudant_borrowMaan20032021-06-131-4/+4
|
* Item search now respects trait impl itemsLukas Wirth2021-06-111-1/+164
|
* Prevent renaming of aliases on usagesLukas Wirth2021-06-051-1/+32
|
* Fix prepare_rename failing for modulesLukas Tobias Wirth2021-05-191-5/+7
|
* Correctly support SelfType when searching for usagesLukas Wirth2021-05-081-0/+17
|
* Check more carefully for cases where a rename can't be doneDanny Zhu2021-04-251-1/+102
| | | | | | | | | | | Attempting to rename an element of a tuple field would previously replace the type with the new name, which doesn't make sense; now it fails instead. The check is done in both `prepare_rename` and `rename` so that the case is caught before the user is prompted for a new name. Some other existing failure cases are also now additionally checked in `prepare_rename`.
* Merge #8267bors[bot]2021-03-311-0/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8267: Adding gifs and screenshots for features in manual r=matklad a=MozarellaMan For #6539 This includes most of gif or screenshot examples of most items in the "Features" header. With the exceptions of: - **On Typing Assists** - couldn't get it to work for a demo, I'm probably missing something? - **Structural search and replace** - looked to be already a visual example of the feature - **Workspace symbol** - wasn't sure how best to show this, all of the examples maybe? Also wasn't sure of the best code example to show it off - **Semantic Syntax Highlighting** - seemed obvious enough to not need a screenshot, but I could easily add this All the gifs/pngs are hosted in this [comment](https://github.com/rust-analyzer/rust-analyzer/issues/6539#issuecomment-809574840). Please let me know if any of them aren't suitable (and why) and I'll improve it! Or if you don't like the theme/font Co-authored-by: Ayomide Bamidele <[email protected]>
| * Gifs and screenshots for features in manualAyomide Bamidele2021-03-311-0/+2
| |
* | Rename target_ty to self_tyLukas Wirth2021-03-291-1/+1
|/
* simplifyLukas Wirth2021-03-231-40/+41
|
* Make more use of the HIR in rename::rename_to_selfLukas Wirth2021-03-231-40/+31
|
* Enable searching for builtin typesLukas Wirth2021-03-151-1/+2
|
* Return original text range in PrepareRename responses when inside macroLukas Wirth2021-03-101-7/+47
|
* Avoid double text edits when renaming mod declarationLukas Wirth2021-03-101-0/+1
|
* Use upstream cov-markLaurențiu Nicola2021-03-081-28/+30
|
* Prevent renaming SelfType and BuiltinTypeLukas Wirth2021-03-031-0/+2
|
* Reorder functions in rename.rsLukas Wirth2021-03-031-189/+187
|
* Update vscode README with a small features listLukas Wirth2021-03-011-0/+9
|
* Implement ast::AstNode for NameLike and move it to node_extLukas Wirth2021-02-161-35/+16
|
* Fix a few clippy::perf warningskjeremy2021-02-161-2/+4
|
* Don't rename field record patterns directlyLukas Wirth2021-02-131-36/+71
|
* Fallback to renaming input NameRef node for macros when inside macroLukas Wirth2021-02-131-16/+53
|
* Prevent aliases from being renamed for nowLukas Wirth2021-02-131-13/+24
|
* Use NameLike in FileReference directly as its not exported from ide anymoreLukas Wirth2021-02-121-7/+5
|
* Refactor reference searching to work with the astLukas Wirth2021-02-121-78/+119
|
* Pin Rust to 1.49.0 on CIJonas Schievink2021-02-121-3/+3
|
* Make always-assert crate reusableAleksey Kladov2021-01-261-3/+3
|
* Remove obsolete RangeInfo usage in renameLukas Wirth2021-01-181-166/+148
|
* Make rename reference search use ide_db::search directlyLukas Wirth2021-01-181-163/+209
|
* Wrap remaining self/super/crate in Name{Ref}Lukas Wirth2021-01-151-44/+32
|
* Handle self/super/crate in PathSegment as NameRefLukas Wirth2021-01-151-1/+1
|
* Phase out SourceFileEdits in favour of a plain HashMapLukas Wirth2021-01-141-100/+95
|
* Group file source edits by FileIdLukas Wirth2021-01-141-81/+57
|
* Merge #7262bors[bot]2021-01-131-3/+0
|\ | | | | | | | | | | | | | | | | 7262: Don't show internal server error on rename r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't show internal server error on renameAleksey Kladov2021-01-131-3/+0
| | | | | | | | | | | | | | Doesn't quite work due to https://github.com/microsoft/vscode-languageserver-node/issues/730 Note that this intentionally removes `impl std::Error for RenameError` -- we nether want to blindly bubble the rename error.
* | Ensure uniqueness of file ids in reference search via hashmapLukas Wirth2021-01-121-8/+12
| |
* | Group references by FileIdLukas Wirth2021-01-121-47/+47
|/
*-. Merge #7051 #7219 #7245 #7246bors[bot]2021-01-111-79/+161
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7051: Check dbg! macro in tidy_test r=matklad a=edwin0cheng Same as `check_todo` but for dbg! macro r? @matklad 7219: Refactor rename name checking r=matklad a=Veykril Improves the user facing error messages a bit and prevents renaming to `_` when the name is referenced as this would change source to not compile anymore since `_` is only a pattern, not a proper identifier. 7245: Encourage gifs r=matklad a=matklad bors r+ 🤖 7246: Unfreeze cargo_metadata r=matklad a=kjeremy It now pulls in a newer version of semver-parser. This does add a dependency on `cargo-platform` in the interest of correctness. Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * Add some more marks to rename testsLukas Wirth2021-01-101-17/+58
| | |
| | * Use local error macros in references/renameLukas Wirth2021-01-101-39/+30
| | |
| | * Refactor rename name checkingLukas Wirth2021-01-091-53/+103
| |/
* / Fixed typos in code commentsVincent Esche2021-01-091-2/+2
|/
* Change <|> to $0 - RebaseKevaundray Wedderburn2021-01-071-46/+46
|
* Merge #7030bors[bot]2020-12-241-0/+25
|\ | | | | | | | | | | | | | | | | | | 7030: Support labels in reference search r=matklad a=Veykril Implements general navigation for labels, goto def, rename and gives labels their own semantic highlighting class. Fixes #6966 Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 06:51:18 +0100