aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_hir
Commit message (Collapse)AuthorAgeFilesLines
* Try to make go to definition work in format!Florian Diebold2019-12-061-5/+18
| | | | | | | SourceAnalyzer didn't work properly within expression macro expansions because it didn't find the enclosing function. Fix this by going up the expansion chain to find ancestors. This makes the test work, but apparently in real usage it's still not working.
* Merge #2479bors[bot]2019-12-053-5/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2479: Add expansion infrastructure for derive macros r=matklad a=flodiebold I thought I'd experiment a bit with attribute macro/derive expansion, and here's what I've got so far. It has dummy implementations of the Copy / Clone derives, to show that the approach works; it doesn't add any attribute macro support, but I think that fits into the architecture. Basically, during raw item collection, we look at the attributes and generate macro calls for them if necessary. Currently I only do this for derives, and just add the derive macro calls as separate calls next to the item. I think for derives, it's important that they don't obscure the actual item, since they can't actually change it (e.g. sending the item token tree through macro expansion unnecessarily might make completion within it more complicated). Attribute macros would have to be recognized at that stage and replace the item (i.e., the raw item collector will just emit an attribute macro call, and not the item). I think when we implement this, we should try to recognize known inert attributes, so that we don't do macro expansion unnecessarily; anything that isn't known needs to be treated as a possible attribute macro call (since the raw item collector can't resolve the macro yet). There's basically no name resolution for attribute macros implemented, I just hardcoded the built-in derives. In the future, the built-ins should work within the normal name resolution infrastructure; the problem there is that the builtin stubs in `std` use macros 2.0, which we don't support yet (and adding support is outside the scope of this). One aspect that I don't really have a solution for, but I don't know how important it is, is removing the attribute itself from its input. I'm pretty sure rustc leaves out the attribute macro from the input, but to do that, we'd have to create a completely new syntax node. I guess we could do it when / after converting to a token tree. Co-authored-by: Florian Diebold <[email protected]>
| * Add expansion infrastructure for derive macrosFlorian Diebold2019-12-053-5/+9
| |
* | Reduce copy-pasteAleksey Kladov2019-12-051-20/+30
| |
* | Introduce ChildFromSourceAleksey Kladov2019-12-051-101/+40
|/
* One pub function less is good!ice10002019-12-051-5/+4
|
* No block at the momentice10002019-12-041-1/+1
|
* Remove almost unused `ModuleSource::new`ice10002019-12-041-1/+1
|
* Confluent `ModuleSource` usageice10002019-12-041-5/+1
|
* Add `ModuleSource::Block`ice10002019-12-045-69/+15
|
* Replace `ra_hir_expand::either` with crateice10002019-12-035-12/+17
|
* Add BuiltinShadowModeEdwin Cheng2019-11-301-1/+1
|
* Move source-related traits to a separate moduleAleksey Kladov2019-11-281-1/+4
|
* Use InFile for AstIdAleksey Kladov2019-11-281-1/+1
|
* Rename Source -> InFileAleksey Kladov2019-11-285-67/+67
|
* Use Name::missing consistentlyAleksey Kladov2019-11-271-10/+7
|
* Minimize APIAleksey Kladov2019-11-271-8/+1
|
* ReformatAleksey Kladov2019-11-271-6/+5
|
* Rename module_id -> local_idAleksey Kladov2019-11-273-16/+16
|
* prune depsAleksey Kladov2019-11-271-20/+0
|
* Move TyAleksey Kladov2019-11-2728-12229/+46
|
* DecoupleAleksey Kladov2019-11-271-20/+15
|
* Remove TypableDefAleksey Kladov2019-11-274-98/+7
|
* Cleanup importsAleksey Kladov2019-11-272-3/+3
|
* Use Id for variatsAleksey Kladov2019-11-277-52/+60
|
* More decouplingAleksey Kladov2019-11-274-33/+27
|
* Decouple moreAleksey Kladov2019-11-275-40/+41
|
* DecoupleAleksey Kladov2019-11-272-24/+32
|
* DecoupleAleksey Kladov2019-11-274-49/+61
|
* Cleanup importsAleksey Kladov2019-11-275-14/+20
|
* DecoupleAleksey Kladov2019-11-274-11/+24
|
* DecoupleAleksey Kladov2019-11-273-19/+29
|
* Crate -> CrateIdAleksey Kladov2019-11-274-35/+37
|
* CleanupAleksey Kladov2019-11-264-74/+82
|
* DecoupleAleksey Kladov2019-11-265-45/+42
|
* Merge #2420bors[bot]2019-11-263-7/+8
|\ | | | | | | | | | | | | | | 2420: Remove last traces of adt from Ty r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Remove last traces of adt from TyAleksey Kladov2019-11-263-6/+7
| |
| * More precise NameKind::SelfAleksey Kladov2019-11-261-1/+1
| |
* | Merge #2418bors[bot]2019-11-261-4/+2
|\ \ | |/ |/| | | | | | | | | | | 2418: Hide MacroCallLoc outside hir_expand r=matklad a=edwin0cheng This PR refactor `MacroCallLoc` such that it be hided to become implementation details of hir_expand. Co-authored-by: Edwin Cheng <[email protected]>
| * Hide MacroCallLocEdwin Cheng2019-11-261-4/+2
| |
* | Remove ns-polymorphic type_for_defAleksey Kladov2019-11-268-164/+127
| |
* | Cleanup importsAleksey Kladov2019-11-262-6/+7
| |
* | Reduce visibilityAleksey Kladov2019-11-262-4/+5
| |
* | Use TraitId in TraitRefAleksey Kladov2019-11-266-68/+68
| |
* | Remove another helperAleksey Kladov2019-11-263-25/+27
| |
* | DocAleksey Kladov2019-11-261-0/+3
| |
* | Remove assoc_type_by_name helperAleksey Kladov2019-11-265-39/+34
| |
* | Store names in TraitDataAleksey Kladov2019-11-262-8/+5
| |
* | Detangle ty from traits a bitAleksey Kladov2019-11-265-49/+63
|/
* Merge #2406bors[bot]2019-11-261-5/+6
|\ | | | | | | | | | | | | | | 2406: Add hygiene information to SourceAnalyzer r=matklad a=edwin0cheng This should fix https://github.com/rust-analyzer/rust-analyzer/pull/2392#issuecomment-557964686 Co-authored-by: Edwin Cheng <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-15 09:39:22 +0000