aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide/src/completion
Commit message (Collapse)AuthorAgeFilesLines
* don't complete top level attrs inside nested attrs and add better labels #4899Benjamin Coenen2020-06-221-8/+1
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* don't complete top level attrs inside nested attrs and add better labels #4899Benjamin Coenen2020-06-211-16/+105
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* don't complete top level attrs inside nested attrs and add better labels #4890Benjamin Coenen2020-06-181-16/+8
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* don't complete top level attrs inside nested attrs and add better labels #4890Benjamin Coenen2020-06-151-63/+123
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Deprecate hir::Path::from_astAleksey Kladov2020-06-151-0/+1
|
* Merge #4868bors[bot]2020-06-131-4/+4
|\ | | | | | | | | | | | | | | | | | | | | 4868: Fix if and while postfix completions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix if and while postfix completionsAleksey Kladov2020-06-131-4/+4
| |
* | More concise completion testsAleksey Kladov2020-06-132-182/+146
| |
* | CleanupAleksey Kladov2020-06-134-255/+154
| |
* | Add keywords completions on source file positionMikhail Rakhmanov2020-06-133-21/+124
| |
* | Fix tests and remove unused methodsMikhail Rakhmanov2020-06-133-13/+6
| |
* | Add more patterns, tests and fix keywordsMikhail Rakhmanov2020-06-123-473/+297
| |
* | Rewrite snapshot checksMikhail Rakhmanov2020-06-124-245/+100
| |
* | Remove comment and incorrect assertMikhail Rakhmanov2020-06-121-7/+1
| |
* | Return snapshots to testsMikhail Rakhmanov2020-06-121-18/+34
| |
* | More assert refactoringMikhail Rakhmanov2020-06-121-7/+8
| |
* | Add more pattern testsMikhail Rakhmanov2020-06-122-11/+50
| |
* | New testing approach for keywordsMikhail Rakhmanov2020-06-122-6/+56
| |
* | Add few smoke tests for patterns and refactoringMikhail Rakhmanov2020-06-114-10/+111
| |
* | Add more patterns and keywordsMikhail Rakhmanov2020-06-113-55/+59
| |
* | Add todoMikhail Rakhmanov2020-06-111-1/+2
| |
* | Add more keywordsMikhail Rakhmanov2020-06-113-234/+182
| |
* | Add top level keywords completionMikhail Rakhmanov2020-06-021-1/+186
|/
* Move the rest of the features to generated docsAleksey Kladov2020-05-311-3/+3
|
* Merge #4592bors[bot]2020-05-272-1/+48
|\ | | | | | | | | | | | | | | 4592: fix textedit range returned for completion when left token is a keyword r=bnjjj a=bnjjj close #4545 Co-authored-by: Benjamin Coenen <[email protected]>
| * fix textedit range returned for completion when left token is a keywordBenjamin Coenen2020-05-272-0/+3
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * fix textedit range returned for completion when left token is a keyword #4545Benjamin Coenen2020-05-242-1/+45
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #4596bors[bot]2020-05-271-1/+59
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * | Trim at presentation layerYuki Kodama2020-05-251-1/+1
| | |
| * | Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| | |
| * | Separate assertionsYuki Kodama2020-05-251-7/+65
| | |
| * | Reflect test caseYuki Kodama2020-05-251-7/+7
| |/
| |
| \
*-. \ Merge #4625 #4629bors[bot]2020-05-271-3/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| |/ / | | | | | | | | | Closes #4628
* / / Pass trivially copy types as copykjeremy2020-05-261-32/+29
|/ /
* | Merge #4534bors[bot]2020-05-261-0/+59
|\ \ | |/ |/| | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]>
| * Add call postfix completionvain0x2020-05-201-0/+59
| | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc.
* | Cleanup TextEditAleksey Kladov2020-05-211-2/+2
|/
* Switch to new magic marksAleksey Kladov2020-05-203-20/+20
|
* Add AssistConfigAleksey Kladov2020-05-191-1/+1
|
* Fix completion and hover for module and function of same nameHasan Ali2020-05-161-1/+29
|
* Prioritize locals with correct typesAleksey Kladov2020-05-142-5/+55
|
* add more specific match postfix for Result and OptionBenjamin Coenen2020-05-121-15/+43
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Merge #4423bors[bot]2020-05-111-0/+26
|\ | | | | | | | | | | | | | | 4423: add tests module snippet r=bnjjj a=bnjjj Request from a friend coming from intellij Rust Co-authored-by: Benjamin Coenen <[email protected]>
| * add tests module snippetBenjamin Coenen2020-05-111-0/+8
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * add tests module snippetBenjamin Coenen2020-05-111-0/+18
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | add if let and while let postfix for Option and ResultBenjamin Coenen2020-05-101-38/+44
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | add if let and while let postfix for Option and Result #4348Benjamin Coenen2020-05-071-1/+199
|/ | | | Signed-off-by: Benjamin Coenen <[email protected]>
* MinorAleksey Kladov2020-05-061-1/+2
|
* Rename AtomTextEdit -> IndelAleksey Kladov2020-05-052-4/+4
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-22 10:59:32 +0100