1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
|
use syntax::{ast, ast::Radix, AstToken};
use crate::{AssistContext, AssistId, AssistKind, Assists, GroupLabel};
// Assist: convert_integer_literal
//
// Converts the base of integer literals to other bases.
//
// ```
// const _: i32 = 10<|>;
// ```
// ->
// ```
// const _: i32 = 0b1010;
// ```
pub(crate) fn convert_integer_literal(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
let literal = ctx.find_node_at_offset::<ast::Literal>()?;
let literal = match literal.kind() {
ast::LiteralKind::IntNumber(it) => it,
_ => return None,
};
let radix = literal.radix();
let value = literal.value()?;
let suffix = literal.suffix();
let range = literal.syntax().text_range();
let group_id = GroupLabel("Convert integer base".into());
for &target_radix in Radix::ALL {
if target_radix == radix {
continue;
}
let mut converted = match target_radix {
Radix::Binary => format!("0b{:b}", value),
Radix::Octal => format!("0o{:o}", value),
Radix::Decimal => value.to_string(),
Radix::Hexadecimal => format!("0x{:X}", value),
};
let label = format!("Convert {} to {}{}", literal, converted, suffix.unwrap_or_default());
// Appends the type suffix back into the new literal if it exists.
if let Some(suffix) = suffix {
converted.push_str(suffix);
}
acc.add_group(
&group_id,
AssistId("convert_integer_literal", AssistKind::RefactorInline),
label,
range,
|builder| builder.replace(range, converted),
);
}
Some(())
}
#[cfg(test)]
mod tests {
use crate::tests::{check_assist_by_label, check_assist_not_applicable, check_assist_target};
use super::*;
#[test]
fn binary_target() {
check_assist_target(convert_integer_literal, "const _: i32 = 0b1010<|>;", "0b1010");
}
#[test]
fn octal_target() {
check_assist_target(convert_integer_literal, "const _: i32 = 0o12<|>;", "0o12");
}
#[test]
fn decimal_target() {
check_assist_target(convert_integer_literal, "const _: i32 = 10<|>;", "10");
}
#[test]
fn hexadecimal_target() {
check_assist_target(convert_integer_literal, "const _: i32 = 0xA<|>;", "0xA");
}
#[test]
fn binary_target_with_underscores() {
check_assist_target(convert_integer_literal, "const _: i32 = 0b10_10<|>;", "0b10_10");
}
#[test]
fn octal_target_with_underscores() {
check_assist_target(convert_integer_literal, "const _: i32 = 0o1_2<|>;", "0o1_2");
}
#[test]
fn decimal_target_with_underscores() {
check_assist_target(convert_integer_literal, "const _: i32 = 1_0<|>;", "1_0");
}
#[test]
fn hexadecimal_target_with_underscores() {
check_assist_target(convert_integer_literal, "const _: i32 = 0x_A<|>;", "0x_A");
}
#[test]
fn convert_decimal_integer() {
let before = "const _: i32 = 1000<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0b1111101000;",
"Convert 1000 to 0b1111101000",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0o1750;",
"Convert 1000 to 0o1750",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0x3E8;",
"Convert 1000 to 0x3E8",
);
}
#[test]
fn convert_hexadecimal_integer() {
let before = "const _: i32 = 0xFF<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0b11111111;",
"Convert 0xFF to 0b11111111",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0o377;",
"Convert 0xFF to 0o377",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 255;",
"Convert 0xFF to 255",
);
}
#[test]
fn convert_binary_integer() {
let before = "const _: i32 = 0b11111111<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0o377;",
"Convert 0b11111111 to 0o377",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 255;",
"Convert 0b11111111 to 255",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0xFF;",
"Convert 0b11111111 to 0xFF",
);
}
#[test]
fn convert_octal_integer() {
let before = "const _: i32 = 0o377<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0b11111111;",
"Convert 0o377 to 0b11111111",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 255;",
"Convert 0o377 to 255",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0xFF;",
"Convert 0o377 to 0xFF",
);
}
#[test]
fn convert_integer_with_underscores() {
let before = "const _: i32 = 1_00_0<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0b1111101000;",
"Convert 1_00_0 to 0b1111101000",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0o1750;",
"Convert 1_00_0 to 0o1750",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0x3E8;",
"Convert 1_00_0 to 0x3E8",
);
}
#[test]
fn convert_integer_with_suffix() {
let before = "const _: i32 = 1000i32<|>;";
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0b1111101000i32;",
"Convert 1000i32 to 0b1111101000i32",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0o1750i32;",
"Convert 1000i32 to 0o1750i32",
);
check_assist_by_label(
convert_integer_literal,
before,
"const _: i32 = 0x3E8i32;",
"Convert 1000i32 to 0x3E8i32",
);
}
#[test]
fn convert_overflowing_literal() {
let before = "const _: i32 =
111111111111111111111111111111111111111111111111111111111111111111111111<|>;";
check_assist_not_applicable(convert_integer_literal, before);
}
}
|
