1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
use crate::{
assist_context::{AssistContext, Assists},
AssistId,
};
use syntax::{
ast::{self, NameOwner},
AstNode, SyntaxKind, SyntaxNode, SyntaxText,
};
use test_utils::mark;
// Assist: generate_default_from_new
//
// Generates default implementation from new method.
//
// ```
// struct Example { _inner: () }
//
// impl Example {
// pub fn n$0ew() -> Self {
// Self { _inner: () }
// }
// }
// ```
// ->
// ```
// struct Example { _inner: () }
//
// impl Example {
// pub fn new() -> Self {
// Self { _inner: () }
// }
// }
//
// impl Default for Example {
// fn default() -> Self {
// Self::new()
// }
// }
// ```
pub(crate) fn generate_default_from_new(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
let fn_node: ast::Fn = ctx.find_node_at_offset()?;
let fn_name = fn_node.name()?.to_string();
if !fn_name.eq("new") {
mark::hit!(other_function_than_new);
return None;
}
if fn_node.param_list()?.params().count() != 0 {
mark::hit!(new_function_with_parameters);
return None;
}
let insert_after = scope_for_fn_insertion_node(&fn_node.syntax())?;
let impl_obj = ast::Impl::cast(insert_after)?;
let struct_name = impl_obj.self_ty()?.syntax().text();
let default_fn_syntax = default_fn_node_for_new(struct_name);
acc.add(
AssistId("generate_default_from_new", crate::AssistKind::Generate),
"Generate a Default impl from a new fn",
impl_obj.syntax().text_range(),
move |builder| {
// FIXME: indentation logic can also go here.
// let new_indent = IndentLevel::from_node(&insert_after);
let insert_location = impl_obj.syntax().text_range().end();
builder.insert(insert_location, default_fn_syntax);
},
)
}
fn scope_for_fn_insertion_node(node: &SyntaxNode) -> Option<SyntaxNode> {
node.ancestors().into_iter().find(|node| node.kind() == SyntaxKind::IMPL)
}
fn default_fn_node_for_new(struct_name: SyntaxText) -> String {
// FIXME: Update the implementation to consider the code indentation.
format!(
r#"
impl Default for {} {{
fn default() -> Self {{
Self::new()
}}
}}"#,
struct_name
)
}
#[cfg(test)]
mod tests {
use crate::tests::{check_assist, check_assist_not_applicable};
use super::*;
#[test]
fn generate_default() {
check_assist(
generate_default_from_new,
r#"
struct Example { _inner: () }
impl Example {
pub fn ne$0w() -> Self {
Self { _inner: () }
}
}
fn main() {}
"#,
r#"
struct Example { _inner: () }
impl Example {
pub fn new() -> Self {
Self { _inner: () }
}
}
impl Default for Example {
fn default() -> Self {
Self::new()
}
}
fn main() {}
"#,
);
}
#[test]
fn generate_default2() {
check_assist(
generate_default_from_new,
r#"
struct Test { value: u32 }
impl Test {
pub fn ne$0w() -> Self {
Self { value: 0 }
}
}
"#,
r#"
struct Test { value: u32 }
impl Test {
pub fn new() -> Self {
Self { value: 0 }
}
}
impl Default for Test {
fn default() -> Self {
Self::new()
}
}
"#,
);
}
#[test]
fn new_function_with_parameters() {
mark::check!(new_function_with_parameters);
check_assist_not_applicable(
generate_default_from_new,
r#"
struct Example { _inner: () }
impl Example {
pub fn $0new(value: ()) -> Self {
Self { _inner: value }
}
}
"#,
);
}
#[test]
fn other_function_than_new() {
mark::check!(other_function_than_new);
check_assist_not_applicable(
generate_default_from_new,
r#"
struct Example { _inner: () }
impl Exmaple {
pub fn a$0dd() -> Self {
Self { _inner: () }
}
}
"#,
);
}
// #[test]
// fn default_block_is_already_present() {
// check_assist_not_applicable(generate_default_from_new,
// r#"
// struct Example { _inner: () }
// impl Exmaple {
// pub fn n$0ew() -> Self {
// Self { _inner: () }
// }
// }
// impl Default for Example {
// fn default() -> Self {
// Self::new()
// }
// }
// "#,
// );
// }
#[test]
fn standalone_new_function() {
check_assist_not_applicable(
generate_default_from_new,
r#"
fn n$0ew() -> u32 {
0
}
"#,
);
}
}
|
