aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVeetaha <[email protected]>2020-03-08 16:58:02 +0000
committerVeetaha <[email protected]>2020-03-08 16:58:02 +0000
commit6bd1ff16e5e517c89a154b9b26847d20656e1184 (patch)
tree68958b95faf5dad2bf3fd0f7457903a2cdeeed61
parent49b4e88458561986009f3cb9dee8879a0649049e (diff)
vscode: rename alwaysDownloadServer -> askBeforeDownload
The new name seems much simpler and it doesn't limit this config value only to downloading the server binary. Thus we wouldn't need to create another config properties to handle other downloads whatsoever. Anyway, I believe (heuristically) that most of the users would want to set "askBeforeDownload": false once and never bother clicking on the notification again (because otherwise there is no big point in installing rust-analyzer if it cannot install the server)
-rw-r--r--docs/user/readme.adoc2
-rw-r--r--editors/code/package.json6
-rw-r--r--editors/code/src/config.ts2
3 files changed, 5 insertions, 5 deletions
diff --git a/docs/user/readme.adoc b/docs/user/readme.adoc
index fb3312614..4ce05a26c 100644
--- a/docs/user/readme.adoc
+++ b/docs/user/readme.adoc
@@ -43,7 +43,7 @@ image::https://user-images.githubusercontent.com/9021944/75067008-17502500-54ba-
43> Note: to disable this notification put the following to `settings.json` 43> Note: to disable this notification put the following to `settings.json`
44> ```json 44> ```json
45{ 45{
46 "rust-analyzer.alwaysDownloadServer": true 46 "rust-analyzer.askBeforeDownload": false
47} 47}
48``` 48```
49 49
diff --git a/editors/code/package.json b/editors/code/package.json
index 7bcd45e15..430a61c64 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -219,10 +219,10 @@
219 } 219 }
220 } 220 }
221 }, 221 },
222 "rust-analyzer.alwaysDownloadServer": { 222 "rust-analyzer.askBeforeDownload": {
223 "type": "boolean", 223 "type": "boolean",
224 "default": false, 224 "default": true,
225 "description": "Whether to ask before downloading the language server binary" 225 "description": "Whether to ask for permission before downloading any files from the Internet"
226 }, 226 },
227 "rust-analyzer.serverPath": { 227 "rust-analyzer.serverPath": {
228 "type": [ 228 "type": [
diff --git a/editors/code/src/config.ts b/editors/code/src/config.ts
index c4acb632d..cb9af86c0 100644
--- a/editors/code/src/config.ts
+++ b/editors/code/src/config.ts
@@ -134,7 +134,7 @@ export class Config {
134 file: prebuiltBinaryName, 134 file: prebuiltBinaryName,
135 storage: this.ctx.globalState, 135 storage: this.ctx.globalState,
136 tag: Config.extensionVersion, 136 tag: Config.extensionVersion,
137 askBeforeDownload: !(this.cfg.get("alwaysDownloadServer") as boolean), 137 askBeforeDownload: !(this.cfg.get("askBeforeDownload") as boolean),
138 repo: { 138 repo: {
139 name: "rust-analyzer", 139 name: "rust-analyzer",
140 owner: "rust-analyzer", 140 owner: "rust-analyzer",