aboutsummaryrefslogtreecommitdiff
path: root/crates/ide
diff options
context:
space:
mode:
authorZac Pullar-Strecker <[email protected]>2020-09-01 00:38:32 +0100
committerZac Pullar-Strecker <[email protected]>2020-10-08 03:01:30 +0100
commita14194b428efdb09cc45f9862ec34bef0038cd35 (patch)
treed069e22d7d162c719fd3a8eb388fc7052e0e7668 /crates/ide
parent8c32bdea3662f4c65810e2d92569b0cb4e3872d9 (diff)
Changes from review
Diffstat (limited to 'crates/ide')
-rw-r--r--crates/ide/src/doc_links.rs3
-rw-r--r--crates/ide/src/lib.rs2
2 files changed, 1 insertions, 4 deletions
diff --git a/crates/ide/src/doc_links.rs b/crates/ide/src/doc_links.rs
index 1e102997f..7fe88577d 100644
--- a/crates/ide/src/doc_links.rs
+++ b/crates/ide/src/doc_links.rs
@@ -100,9 +100,6 @@ pub fn get_doc_link<T: Resolvable + Clone>(db: &dyn HirDatabase, definition: &T)
100// BUG: For Option 100// BUG: For Option
101// Returns https://doc.rust-lang.org/nightly/core/prelude/v1/enum.Option.html#variant.Some 101// Returns https://doc.rust-lang.org/nightly/core/prelude/v1/enum.Option.html#variant.Some
102// Instead of https://doc.rust-lang.org/nightly/core/option/enum.Option.html 102// Instead of https://doc.rust-lang.org/nightly/core/option/enum.Option.html
103//
104// BUG: For methods
105// import_map.path_of(ns) fails, is not designed to resolve methods
106fn get_doc_link_impl(db: &dyn HirDatabase, moddef: &ModuleDef) -> Option<String> { 103fn get_doc_link_impl(db: &dyn HirDatabase, moddef: &ModuleDef) -> Option<String> {
107 // Get the outermost definition for the moduledef. This is used to resolve the public path to the type, 104 // Get the outermost definition for the moduledef. This is used to resolve the public path to the type,
108 // then we can join the method, field, etc onto it if required. 105 // then we can join the method, field, etc onto it if required.
diff --git a/crates/ide/src/lib.rs b/crates/ide/src/lib.rs
index b92e6d9ea..0580d2979 100644
--- a/crates/ide/src/lib.rs
+++ b/crates/ide/src/lib.rs
@@ -383,7 +383,7 @@ impl Analysis {
383 } 383 }
384 384
385 /// Return URL(s) for the documentation of the symbol under the cursor. 385 /// Return URL(s) for the documentation of the symbol under the cursor.
386 pub fn get_doc_url( 386 pub fn external_docs(
387 &self, 387 &self,
388 position: FilePosition, 388 position: FilePosition,
389 ) -> Cancelable<Option<doc_links::DocumentationLink>> { 389 ) -> Cancelable<Option<doc_links::DocumentationLink>> {